Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common File Manager Operation (move, rename, search etc) in web panel #1225

Open
cupang-afk opened this issue Jan 21, 2023 · 4 comments
Open

Comments

@cupang-afk
Copy link

Is your feature request related to a problem? Please describe.
this is kinda annoying when i already uploaded a file and i cant rename nor move it via web panel
also it missing search function for file manager

there is more below

Describe the solution you'd like
add this feature to file manager in web panel

  • move

  • rename

  • search

  • a warn if there any file with same name (when uploading, moving, renaming)

  • a warn when you try to archive a folder with size more than a certain GB
    (i never tried this hence i assume there is no warning, and im afraid to do, because i have small storage)

  • a cancel button when there any archiving process

  • batch upload/download

  • file list inside a page (page 1, page 2, etc)
    for example, listing 10 file in 1 page:

    page 1
    file 1.txt
    file 2.txt
    file 3.txt
    ...
    file 10.txt
    next page button >

    this is because my browser went a bit laggy when i openned the logs folder which has hundred of file

Describe alternatives you've considered
sftp is already the alternative, but i want it in the web panel instead

Additional context
none

@nepcore
Copy link
Member

nepcore commented Jan 21, 2023

move/rename

They're effectively the same thing and already on the radar for v3

search

The browser doesn't have file system access so it'd need to iterate through all directories asking the server what files exist there which can end up insanely slow if there are many nested directories in a server (e.g. minecraft world dirs)
Asking the server to search through the files needs caution as well as the server having direct file system access means that it could starve your IO if e.g. too many users search for files in servers with many directories at the same time (and I wouldn't be surprised if it's not all that hard to reach that point)

warn about already existing files

Also already on the radar for v3

warn about archiving lots of data

The archiving process doesn't run in the client, but on the server, if there's not enough disk space for the archive it'll fail, otherwise it doesn't bother your browser

cancel archiving

As mentioned before, archiving is done server side, making it not all that easy to just cancel that, it's possible, but it's questionable if the required effort is actually worth it

batch upload/download

If you're talking about uploading multiple files at once, that's a thing already, at least if your OS/browser support it (e.g. with FireFox on desktop you can just shift or ctrl click files to select multiple)
If you're talking about uploading a directory, tell the W3C to figure out a reasonable standard for that, because so far none exists, making it impossible to support that past a few desktop browsers that may or may not implement a non-standard API more or less correctly

paged file list

Paging won't help with your issues, the server returns all files in a directory and the browser has to go through them all, no matter how many of them it does and doesn't display to you, v2 has a few situations where its performance on the client goes down the drain a bit, v3 will rectify a lot of that
If your browser always starts to die when rendering more than a 100 HTML elements it'll struggle with most somewhat modern sites and you might need to upgrade your potato to a toaster


In general, web browsers don't give web applications a lot of options for working with files, mostly in the interest of security which is totally fine, but also fail hard at supplying secure alternatives for a lot of things
That combined with the sometimes less than usable APIs browsers provide (drag and drop is one hell of a mess...) and the fact that file managers are quite complex applications once looking past the surface makes it really hard to implement a fully featured file manager in a browser and you'll likely always need to resort to other methods like SFTP for something

@cupang-afk
Copy link
Author

i see

atleast the move/rename function is being worked

i want to ask one more about the text editor
is it posible to change the color scheme ?
you know, for easier to read

or is it already covered by the theme ?

@nepcore
Copy link
Member

nepcore commented Jan 22, 2023

Hit ctrl+, with an editor open to get a settings overlay, that's all v2 can do editor theming wise

v3 will have a much more powerful theming engine though

@iwa
Copy link

iwa commented Apr 3, 2023

any ETA on that by any chance? not being able to rename/move is really annoying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants