Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browsable Time Slider #22

Open
IshaGupta18 opened this issue May 17, 2019 · 20 comments
Open

Browsable Time Slider #22

IshaGupta18 opened this issue May 17, 2019 · 20 comments
Labels
enhancement New feature or request gsoc help wanted Extra attention is needed summer of code

Comments

@IshaGupta18
Copy link
Collaborator

I was trying to make the browsable time slider using https://github.com/schme16/Chart.js-RangeSlider .

But when I included the script file https://gitcdn.link/cdn/schme16/Chart.js-RangeSlider/677a7eb6c295772606d300697eaf552245e7f171/dist/RangeSlider-all.min.js, it seems to be interfering with the bootstrap's JS file and shows an error like

image

What could be the reason that the scripts are interfering with each other? Is there a way to fix it, because I tried but couldn't, we can keep trying or any other suggestions for time sliders? @jywarren @namangupta01 Thank You!
@IshaGupta18
Copy link
Collaborator Author

Okay, so I updated the code and found out that I was accidentally plotting the sample data instead of the complete data. Apologies for that. The graphs will now look more cluttered like this:
image

So we will need to think some stuff through. The requirement for a range slider becomes an absolute necessity now and we will have to refine the graph UI for best results. Kindly give your views on it. Thank you!

@namangupta01
Copy link
Member

I think if that is occurring with the bootstrap, we can't fix it. In that case, it would be better to use something else than bootstrap?

@namangupta01
Copy link
Member

But as I see the error is not due to Bootstrap. This would work super.

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 19, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 19, 2019 via email

@namangupta01
Copy link
Member

We are making this library standalone which means it would be used by the public lab as well as any other users also. So it would be better if we give them the freedom whether they want to use or not. We should give a default design and if the user of this library wants to improve the css he can do so.

@namangupta01
Copy link
Member

Don't think of only using this for PublicLab anyone should be able to use it on their website. Right?
What do you think?

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 19, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

@jywarren @namangupta01 what do you think might be causing the problem here?

@IshaGupta18
Copy link
Collaborator Author

@gauravano @SidharthBansal @Souravirus kindly help me out here a little!

@grvsachdeva grvsachdeva added bug Something isn't working help wanted Extra attention is needed enhancement New feature or request and removed bug Something isn't working labels May 21, 2019
@grvsachdeva
Copy link
Member

@IshaGupta18 are you still facing this issue?

@grvsachdeva
Copy link
Member

Also, can you please push the sample CSV file so that everyone can be on the same page format wise? Thanks!

@grvsachdeva
Copy link
Member

I have to press upload every time to plot the graph so how about having an explicit button for that? Also, I wasn't able to test upload using the URL as I am getting CORS. I tried using - http://insight.dev.schoolwires.com/HelpAssets/C2Assets/C2Files/C2ImportCalEventSample.csv.

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 21, 2019 via email

@IshaGupta18
Copy link
Collaborator Author

hey, this file works for me! I think it didn't work for you because the latest changes and few bugs were fixed in the PRs I have raised.
image

image

@IshaGupta18
Copy link
Collaborator Author

@gauravano what do you think?

This was referenced May 28, 2019
Closed
Open
@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 28, 2019 •
edited

Okay so I have fixed this carousel bug! yay! But here's the new one which is creating a problem

image

Here's the snippet of the code causing it:

image

So basically the range-slider is not getting initialized properly.

Although, I have written it very similar to the working fiddle here: http://jsfiddle.net/schme16/xfyvvup8/

What do you think is creating a problem? I'll push the code if you need it! I will really appreciate some help here! Thank you

cc: @Souravirus

@Souravirus
Copy link
Member

Hi @IshaGupta18, can you send larger screenshots as these are not visible. I think that if you push the code somewhere or send it in a gist, that would be really great.
Thank you!!

@IshaGupta18
Copy link
Collaborator Author

IshaGupta18 commented May 28, 2019 via email

@IshaGupta18 IshaGupta18 mentioned this issue May 28, 2019
Open
@IshaGupta18
Copy link
Collaborator Author

#31 will help you with the code @Souravirus. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gsoc help wanted Extra attention is needed summer of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Souravirus @namangupta01 @grvsachdeva @IshaGupta18