Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Planning] Geographic Features Refinement #9698

Open
daemon1024 opened this issue May 30, 2021 · 11 comments
Open

[Planning] Geographic Features Refinement #9698

daemon1024 opened this issue May 30, 2021 · 11 comments
Assignees
Labels

Comments

@daemon1024
Copy link
Member

daemon1024 commented May 30, 2021

Succeeds #1416

This is currently broad planning points for the project. I will be detailing out, break it further, adding more relevant tasks.

@daemon1024 daemon1024 self-assigned this May 30, 2021
@ebarry
Copy link
Member

ebarry commented Jun 8, 2021

Let's keep this milestone, I"ll update it with this planning issue. Thanks!

@daemon1024 daemon1024 added this to the Geographic features milestone Jun 8, 2021
@daemon1024
Copy link
Member Author

publiclab/leaflet-environmental-layers#121 I was wondering if spinning it out the component as Leaflet Plugin, would ease out our scripts and workflow.

What are your thoughts about this @jywarren ?

@daemon1024
Copy link
Member Author

daemon1024 commented Jun 12, 2021

publiclab/leaflet-environmental-layers#480 Bumping this issue and planning to add to tasklist.

Have we consider adding a guide/docs which doesn't require people to download/install things? Using CDNs like jsdelivr or unpkg. This would ease out for someone who is wanting to try it out without needing to externally add anything.

@jywarren
Copy link
Member

publiclab/leaflet-environmental-layers#121 I was wondering if spinning it out the component as Leaflet Plugin, would ease out our scripts and workflow.

What are your thoughts about this @jywarren ?

I like this idea a lot! It'd be a nice output of the fellowship too!

@jywarren
Copy link
Member

Have we consider adding a guide/docs which doesn't require people to download/install things? Using CDNs like jsdelivr or unpkg. This would ease out for someone who is wanting to try it out without needing to externally add anything.

This sounds cool -- sure!

One thing perhaps in terms of prioritization is that the current map at https://publiclab.org/map is really not as useful as we'd hope it to be. I wonder if it's worth a brainstorm of ideas for how to make the experience better. Some ideas that occur to me:

  1. progressively load more content as you zoom/pan (or tune the progressive loading that does happen)
  2. refine the explanations of layers that appear. Many are still unclear in that it's not very legible where the data comes from, how "reliable" it is, etc.

What other ideas might we come up with?

@ebarry
Copy link
Member

ebarry commented Jun 17, 2021

Great ideas here! These seem like ideal goals for the Fellowship on Geographic Features. +1!

It has occurred to me that in the future we could think about:

  • For people who are logged in, but who haven't added their location, we might show an "add your (blurred) location" prompt ? This or something similar might help explain why the map loads on 0,0?
  • For people who are not logged in, might our website "request your location" and use that to move the map to where people are?

also for later -- cartography. The fun stuff :)

@jywarren
Copy link
Member

For people who are logged in, but who haven't added their location, we might show an "add your (blurred) location" prompt ? This or something similar might help explain why the map loads on 0,0?

This prompt would be on the /map page itself? If so, it could mirror the logic and style of the button we show on the dashboard, which shows "Add your location" if you haven't yet. I like this!

For people who are not logged in, might our website "request your location" and use that to move the map to where people are?

I think we could, but we often request location as part of the blurred location popup itself, when we do so to save that location to ones' profile. So we would have to think about whether it's redundant to ask here, or if we can clearly and simply describe how this "request your location" prompt is not /saving/ the location, but merely /displaying/ it for you, and so, relatively, preserving your privacy? Or is that distinction not really worth trying to explain vs. just getting people to input their blurred location -- does it present too much possible confusion?

Thanks! Good ideas, happy to dig into them further as well!

@jywarren
Copy link
Member

Also noting this issue affecting display of people! publiclab/leaflet-blurred-location-display#123

@daemon1024
Copy link
Member Author

I realised, I haven't noted down my progress in this planning issue.

Regarding Github Actions, the workflow lies at daemon1024/leaflet-environmental-layers#6 and seems to be working fine.

I have started working on the web form which will take the input and in-turn run the above github action . https://daemon1024.github.io/leaflet-environmental-layers/example/form.html

Most of the progress lies inside my personal fork since they are awaiting movement in publiclab/leaflet-environmental-layers#531 which is blocked by publiclab/leaflet-environmental-layers#532

I think my next step would be to start investigating the PL People API while make the above listed items slowly progress into the main repo.

What do you think about this? Thank You.

@jywarren
Copy link
Member

Hi @daemon1024 - this is looking really nice. I just gave it a try and made screenshots which could be used in documentation.

daemon1024/leaflet-environmental-layers#12

Agreed on PL People API which is /super/ slow right now. I'll also look in on the Cypress thing!

@daemon1024
Copy link
Member Author

daemon1024 commented Aug 18, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants