Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change http to https #8910

Closed
5 tasks
first-timers bot opened this issue Dec 31, 2020 · 9 comments · Fixed by #9095
Closed
5 tasks

Change http to https #8910

first-timers bot opened this issue Dec 31, 2020 · 9 comments · Fixed by #9095
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute

Comments

@first-timers
Copy link

first-timers bot commented Dec 31, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/home/nearby.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -15,7 +15,7 @@
     L.tileLayer('https://api.mapbox.com/styles/v1/jywarren/ckj06ujnc1nmi19nuelh46pr9/tiles/{z}/{x}/{y}?access_token=pk.eyJ1Ijoianl3YXJyZW4iLCJhIjoiVzVZcGg3NCJ9.BJ6ArUPuTs1JT9Ssu3K8ig', {
       tileSize: 512,
       zoomOffset: -1,
-      attribution: '© <a href="https://apps.mapbox.com/feedback/">Mapbox</a> © <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>'
+      attribution: '© <a href="https://apps.mapbox.com/feedback/">Mapbox</a> © <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a>'
     }).addTo(map);
 
 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Dec 31, 2020
@cesswairimu
Copy link
Collaborator

Reserved for @harshdhonchak

@cesswairimu
Copy link
Collaborator

Hi @harshdhonchak, are you still working on this? if not, kindly let us know so we can free this up for other contributors. Thanks

@harshdhonchak
Copy link

harshdhonchak commented Jan 6, 2021 via email

@vishnu-muthuswamy
Copy link

Hi! Has @harshdhonchak made a pull request yet for this issue? I am willing to help, if it is needed. I hope to be a first time contributor as well!

@cesswairimu
Copy link
Collaborator

Hi @harshdhonchak, we free-up FTOs if a week goes by with no updates or replies because we assume they have been abandoned. This is to give other contributors a chance, as these types of issues are high in demand now.
If you'd like to try again with a new FTO, we welcome you to!

@vishnu-muthuswamy if you are still looking for an issue feel free to take up this one. Thanks all

@DarinJoshua-dev
Copy link
Contributor

DarinJoshua-dev commented Jan 27, 2021

Hello, have resolved the issue and have submitted a PR, thank you!

@DarinJoshua-dev
Copy link
Contributor

Please Review my PR, thank you

@harshdhonchak
Copy link

harshdhonchak commented Jan 28, 2021 via email

@cesswairimu
Copy link
Collaborator

No worries @harshdhonchak totally understand adding your name here #9083 and we will ping you if one comes along. Thanks

manchere pushed a commit to manchere/plots2 that referenced this issue Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants