Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags in modals of Nodes in Spam2 #8230

Closed
5 tasks
keshavsethi opened this issue Aug 3, 2020 · 3 comments · Fixed by #8238
Closed
5 tasks

Add tags in modals of Nodes in Spam2 #8230

keshavsethi opened this issue Aug 3, 2020 · 3 comments · Fixed by #8238
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@keshavsethi
Copy link
Member

keshavsethi commented Aug 3, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

                  <div class="modal-body">
                    <% node.tags.limit(4).each do |tag| %>
                      <span ><a class="badge badge-primary" href="/questions/tag/<%= tag.name %>"> <%= tag.name %> </a></span>
                    <% end %>
                    <br>
                    <%= node.body %>
                  </div>

It should be something like this:
Screenshot from 2020-08-04 04-36-53

To Test this

  • Login as Moderator or admin
  • Change URL to /Spam2
  • From the menu dropdown go to wiki or bulk moderation
  • Click on any title
  • Check tags in modal

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@keshavsethi keshavsethi added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Aug 3, 2020
@renugasaraswathy
Copy link
Contributor

Hi, I am picking up this issue. Thanks.

@renugasaraswathy
Copy link
Contributor

Have submitted a pull request for this #8238. @cesswairimu @keshavsethi Kindly review.

@renugasaraswathy
Copy link
Contributor

@keshavsethi I would also like to where to write tests for the change I made. Thanks.

cesswairimu pushed a commit that referenced this issue Aug 10, 2020
* adding tags in modals of Nodes #8230

* refactored #8230

* fixed tag path in the modal #8230
also fixed extra spacing when no tags on the modal
jywarren added a commit that referenced this issue Aug 12, 2020
* paginate tag page listings (#8243)

* Update _graph.html.erb

* Update show.html.erb

* topic card count fixes for #7965 (#8249)

* fixes for #7965

* count fixes

* Update _topicCard.html.erb

* Delete _related_tags.html.erb (#8247)

* Fixes to tag counting logic (#8245)

* Update tag_test.rb

* Update tag_test.rb

* Update tag_test.rb

* Update tag.rb

* Spam2: Moderator's Queue  feature (#8196)

* queue feature spam2

* indentation issue

* bulk moderation for comments and tag count in queue

* indentation

* moderator queue

* batch controller

* first-timmer issue

* tag filter

* queue indentation

* all tags filter queue

* Don't let newcomers edit wiki pages (controller-level) (#8250)

* Don't let newcomers edit wiki pages (controller-level)

* Update wiki_controller.rb

* Update wiki_controller_test.rb

* Update wiki_controller_test.rb

* Update wiki_controller_test.rb

* Update wiki_controller_test.rb

* Update wiki_controller.rb

* Update wiki_controller.rb

* Update wiki_controller_test.rb

* Update wiki_controller_test.rb

* Bump rubocop from 0.88.0 to 0.89.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.88.0 to 0.89.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.88.0...v0.89.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump codecov from 0.2.3 to 0.2.5

Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.2.3 to 0.2.5.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-ruby@v0.2.3...v0.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rdiscount from 2.2.0.1 to 2.2.0.2

Bumps [rdiscount](https://github.com/davidfstr/rdiscount) from 2.2.0.1 to 2.2.0.2.
- [Release notes](https://github.com/davidfstr/rdiscount/releases)
- [Changelog](https://github.com/davidfstr/rdiscount/blob/master/CHANGELOG.md)
- [Commits](davidfstr/rdiscount@2.2.0.1...2.2.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Adding tags to Modals of Nodes (#8238)

* adding tags in modals of Nodes #8230

* refactored #8230

* fixed tag path in the modal #8230
also fixed extra spacing when no tags on the modal

* update _flags.html.erb (#8237)

Changed "btn btn-xs" to "btn btn-sm"

* adjust opengraph tag

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Co-authored-by: Keshav Sethi <36025262+keshavsethi@users.noreply.github.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: renugasaraswathy <renugasaraswathy@gmail.com>
Co-authored-by: siddhama <54734665+siddhama@users.noreply.github.com>
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this issue Sep 21, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
cesswairimu pushed a commit that referenced this issue Sep 30, 2020
* adding tags in modals of Nodes #8230

* refactored #8230

* fixed tag path in the modal #8230
also fixed extra spacing when no tags on the modal

* #8277 & #8278 changed UI for Following and Followers page

* #8277 updating no followers / following message
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this issue Oct 12, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this issue Oct 12, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this issue Oct 14, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this issue Oct 14, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
piyushswain pushed a commit to piyushswain/plots2 that referenced this issue Oct 22, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
piyushswain pushed a commit to piyushswain/plots2 that referenced this issue Oct 22, 2020
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
manchere pushed a commit to manchere/plots2 that referenced this issue Feb 13, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
manchere pushed a commit to manchere/plots2 that referenced this issue Feb 13, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
ampwang pushed a commit to ampwang/plots2 that referenced this issue Oct 26, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
ampwang pushed a commit to ampwang/plots2 that referenced this issue Oct 26, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* adding tags in modals of Nodes publiclab#8230

* refactored publiclab#8230

* fixed tag path in the modal publiclab#8230
also fixed extra spacing when no tags on the modal

* publiclab#8277 & publiclab#8278 changed UI for Following and Followers page

* publiclab#8277 updating no followers / following message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants