match hyphens in tags search on /tags with JS Typeahead library

[jywarren]

We made some changes so that the tags search form now searches for hyphenated tags even if you input a string with spaces. For example, searching for:

balloon map actually sends a search for balloon-map and so it matches the tag balloon-mapping correctly.

However, although results are sent back from the server for this search, these results are not displayed. That's because our typeahead library tries to do a second comparison of the results with the typed input, and balloon map doesn't match balloon-mapping, and so nothing is shown.

The code driving this is here:

plots2/app/assets/javascripts/tagging.js

Lines 73 to 86 in cba5499

	el.find('.control-group .help-block').remove();
	el.find('.control-group').append('<span class="help-block">' + response.responseText + '</span>')
	});
	setupTagDelete($('.tag-delete'));
	el.find('.tag-input').typeahead({
	items: 8,
	minLength: 3,
	source: function (query, process) {
	return $.post('/tag/suggested/' + query, {}, function (data) {
	return process(data);
	})
	},

And our library offers a range of options; i think the matcher function could be provided to substitute the hyphens in in local JavaScript, to allow matches with the results:

https://github.com/bassjobsen/Bootstrap-3-Typeahead#options

But it will take some experimentation to get this working! We'd love help with this. Thanks! 🎉

(linking to #5719)

[jywarren]

Screenshot of watching the results return and not match!

[moki298]

I am claiming this, will update on this asap, currently I am setting up the environment for this.

[moki298]

@jywarren This has been fixed, please check #6379