Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up bugs in new designs of All sections including Profile,Tags, People etc #6097

Closed
4 of 6 tasks
CleverFool77 opened this issue Aug 2, 2019 · 73 comments · Fixed by #6103
Closed
4 of 6 tasks

Follow up bugs in new designs of All sections including Profile,Tags, People etc #6097

CleverFool77 opened this issue Aug 2, 2019 · 73 comments · Fixed by #6103
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed design issue requires more design work and discussion (i.e. mockups and sketches)
Projects
UI improvements - Summer Of Code 2019

Comments

@CleverFool77
Copy link
Member

CleverFool77 commented Aug 2, 2019 •
edited by jywarren

@CleverFool77 CleverFool77 added feature explains that the issue is to add a new feature bug the issue is regarding one of our programs which faces problems when a certain task is executed design issue requires more design work and discussion (i.e. mockups and sketches) and removed feature explains that the issue is to add a new feature labels Aug 2, 2019
@CleverFool77
Copy link
Member Author

Hi @jywarren @gautamig54 I had a doubt regarding this -
In the one main card of Individual Tag page , we have a subscribe button but when I click on the button, it shows related tag, but not let us subscribe to that particular tag. We are only able to subscribe to related tags and not the main tag whose Individual page we are on.

Instead we have another button below called Subscribe to answer questions on this topic. And this button is the one which lets us subscribe to tag.

Screenshot from 2019-08-03 12-53-11

This should be fixed right ? Or Is it going to be like this only.

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019 via email

@CleverFool77
Copy link
Member Author

Cool!! I'll fix it.

@CleverFool77 CleverFool77 mentioned this issue Aug 4, 2019
Merged
@gautamig54
Copy link
Contributor

On the individual tags page, for a few tags, the content on the side bar shifts to the bottom. Whereas the page seems to be divided properly.

Screen Shot 2019-08-04 at 10 12 37 PM

@gautamig54
Copy link
Contributor

I think this happens when there are tab content. With no tab contents, it displays it on the right side only.
Can you also generate this issue @CleverFool77?

@CleverFool77
Copy link
Member Author

CleverFool77 commented Aug 5, 2019 via email

@CleverFool77
Copy link
Member Author

Hi @gautamig54 I was able to reproduce this Issue. I'll try fixing it. Cool.
Thanks !!

@gautamig54
Copy link
Contributor

Hi @CleverFool77. I think the problem is with the questions tab. It is working fine for wikis and posts

@CleverFool77
Copy link
Member Author

Hi @gautamig54 I checked it, Its pretty similar to matter when we have the side-wrap issue in tag page without login. I saw that the col-3 sidebar is going out the row class and thus its wrapping up in tab-content. Instead both of them should be inside the div of row class. So I'm checking and trying to work it out.
Thanks !!

@gautamig54
Copy link
Contributor

Hi @CleverFool77! Should we make a separate issue for correcting the responsiveness of pages?

@CleverFool77
Copy link
Member Author

CleverFool77 commented Aug 8, 2019 via email

@CleverFool77
Copy link
Member Author

If you wanna add a new feature then opening an issue would do, In bug we can just checklist here for now ?

@gautamig54
Copy link
Contributor

Sure @CleverFool77 !

@CleverFool77
Copy link
Member Author

Hi @gautamig54 @jywarren
Found this -
I clicked on question and found this -
Screenshot from 2019-08-12 17-02-05

@CleverFool77
Copy link
Member Author

Maybe this is related to Individual tags page ?

@CleverFool77
Copy link
Member Author

I saw the unstable and I don't see any map here. What could be the reason ?
As much as I know, even if the location is not added, a map should be still there. ??

Screenshot from 2019-08-12 17-07-24

@jywarren
Copy link
Member

@ebarry @steviepubliclab how do you feel about the functionality of the Subscribe button opening a dropdown with not only the tag itself but other related tags, in a "multi-subscribe" function, as in the screenshot above (#6097 (comment))? (on tag pages)

This made sense in other places, but now that the tag page is kind of the lead page for a topic-based forum, maybe it should just subscribe you to the tag itself, and if you're subscribed, show unsubscribe? Or do we like this multi-subscribe?

The simpler subscribe/unsubscribe is shown on the /tags page, for comparison:

image

@jywarren
Copy link
Member

Versus on the tag page now:

image

@jywarren
Copy link
Member

Hi! One more I noticed - -perhaps the "X more posts" links in the profile page tag cards should go not just to the tag page, but to the page showing tagged content by that author:

https://publiclab.org/profile/warren

so, to https://publiclab.org/tag/community-atlas/author/warren for example. What do you think?

@CleverFool77 CleverFool77 mentioned this issue Aug 16, 2019
Closed
@CleverFool77
Copy link
Member Author

CleverFool77 commented Aug 16, 2019 •
edited

Hi @jywarren
I found another thing !!

I saw what you wrote about link ! and opened a PR on this !!
But I have one doubt !!
When I clicked on the link, its showed 3 more posts but when I clicked on it, the directed link to list of posts doesn't show those three posts ..

li

Here is full page of new directed page !!

Screenshot from 2019-08-16 11-45-34

The post count for that tag is for profile user only and couldn't be wrong. So I was wondering where the bug and problem could be ?

@jywarren
Copy link
Member

jywarren commented Aug 16, 2019 via email

@CleverFool77
Copy link
Member Author

I'll try this.
Cool.

@CleverFool77
Copy link
Member Author

There is another bug here !!
I have used the tags bu there isn't any note being shown in these topic cards !!

Screenshot from 2019-08-17 18-16-24

@CleverFool77
Copy link
Member Author

Hi @jywarren !!
We had discussed this earlier but Is it still ok to have this much repetition of the notes ?
Like as we can see in screenshot that one of the notes is being repeated a lot. And As I haven't used much tags, so repetition wasn't much compared to a condition when we will have lots of tags in one note.

Screenshot from 2019-08-17 18-18-43

Screenshot from 2019-08-17 18-19-02

Anupam-dagar added a commit to Anupam-dagar/plots2 that referenced this issue Aug 30, 2019
@Anupam-dagar
fix: Rename tags id in profile page.
74c7bb2 
Reference publiclab#6097
@jywarren
Copy link
Member

jywarren commented Aug 30, 2019 via email

@CleverFool77
Copy link
Member Author

CleverFool77 commented Aug 31, 2019 via email

@gautamig54
Copy link
Contributor

Yes. I have limited the content by the number of lines.

@SidharthBansal
Copy link
Member

This is really amazing piece of work folks. Super thanks

SidharthBansal pushed a commit that referenced this issue Sep 3, 2019
@Anupam-dagar @SidharthBansal
fix: Rename tags id in profile page. (#6216)
9add5ab 
Reference #6097
UI improvements - Summer Of Code 2019 automation moved this from In progress Issues to Done Sep 4, 2019
@jywarren
Copy link
Member

jywarren commented Sep 5, 2019

Oops, re-opening! Also, we found this one, could be related to #6027 perhaps...

image

The URL is https://publiclab.org/tag/activity:*/author/mimiss

Thanks!!!

@jywarren jywarren reopened this Sep 5, 2019
UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Sep 5, 2019
@jywarren
Copy link
Member

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

@CleverFool77
Copy link
Member Author

HI @gautamig54 @jywarren
Upcoming week would be my exams , So I won't be able to contribute much. I would be regular from next week onward.

Thanks !!

@CleverFool77
Copy link
Member Author

I noticed the edit button in the new sidebar is not visible in mobile-width devices. Could there be a relatively quick fix for this?

I'll Fix it.
Thanks !!

@SidharthBansal
Copy link
Member

SidharthBansal commented Sep 13, 2019 via email

@jywarren
Copy link
Member

I think i've got the edit button fix in my big new PR here: #6322 -- lots of fixes there!

@CleverFool77
Copy link
Member Author

Thanks for the fix @jywarren .
My exams has ended finally. I'll look for other fixes in the design.
Thanks !!

@jywarren
Copy link
Member

jywarren commented Sep 24, 2019 via email

@jywarren
Copy link
Member

Aha - ok, now the tag page header cards are really in bad shape, and I think I found the issue. These lines set percentage-based positioning, and the use of row/col is a little odd within the card:

plots2/app/views/tag/show.html.erb

Lines 73 to 126 in 02b44b9

.box {
padding: 2%;
margin: 2%;
}
.tag_card{
width : 25em;
border: 1px solid #ccc;
border-radius: 5px;
padding: 20px;
/* padding-left: 20px; */
position: absolute;
top: 22%;
left: 5%;
background-color: white;
}
@media screen and (max-width: 480px) {
.tag_card {
width : 24em;
border: 1px solid #ccc;
border-radius: 5px;
padding: 20px;
position: absolute;
top:100%;
}
.box{
padding: 2%;
margin: 2%;
margin-top: 120%;
}
.col-md-2{
margin-top: -60px;
}
}
.wiki-sub{
overflow: hidden;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
color: #666;
font-size: 13px;
}
.tag-buttons{
padding-top: 30px;
}
.container{
position: relative;
}

If you are able to do some reworking of this, please do, and we'll try to rush it into production late tonight or early tomorrow.

image
image

I think we should set top: 70px and redo the row/col code there. That should address a lot of the other issues with that card as well!

@jywarren
Copy link
Member

That is, the wiki-sub and tag-buttons should be in their own <div class="row">, i think!

@jywarren
Copy link
Member

Quick attempt here: #6328

@jywarren jywarren mentioned this issue Sep 25, 2019
Merged
@jywarren
Copy link
Member

Continued work here: #6330

I am still not getting the background to show up on mobile screens:

image

But everything else is relatively better organized and with fewer custom styles. There are still some custom .card styles however, in /app/views/notes/_notes.html.erb -- I'd prefer to go with strict Bootstrap styles as much as possible, as it helps avoid the kinds of unexpected layout issues we're seeing here! https://getbootstrap.com/docs/4.3/components/card/

@jywarren
Copy link
Member

Oof, made it even worse in some scenarios. It's very strange that there are differences between stable, local, and production!

image

@jywarren
Copy link
Member

OK, did some more work on this, and the latest changes are publishing to the live site now!

@jywarren
Copy link
Member

Lots of pages look much better now!!!

@jywarren
Copy link
Member

I believe this is complete now. Any last follow-ups?

@CleverFool77
Copy link
Member Author

I guess this is ready.
Thanks @jywarren !!!

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed design issue requires more design work and discussion (i.e. mockups and sketches)
Projects
No open projects
UI improvements - Summer Of Code 2019
  
Done
Milestone
No milestone
7 participants
@jywarren @ebarry @simonastefan @SidharthBansal @Anupam-dagar @CleverFool77 @gautamig54