/inline-maps page showing some errors #5678
Comments
jywarren
added
bug
|
More details here : #4722 I made a copy of this page as a I am investigating on why the same content is not working on the |
|
ok, awesome! Thanks so much, Sagarpreet!
…On Wed, May 8, 2019 at 1:46 AM Sagarpreet Chadha ***@***.***> wrote:
More details here : #4722
<#4722>
I made a copy of this page as a note of the main wiki page here :
https://publiclab.org/notes/sagarpreet/01-30-2019/inline-map-testing and
this note is working fine .
I am investigating on why the same content is not working on the wiki page
: https://publiclab.org/wiki/inline-maps . Most probably it is due to
external JS code exclusively coded in /wiki . Thanks :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5678 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2CS5ED3U4UZ6RM6FTPUJSIBANCNFSM4HLMQT4Q>
.
|
|
Let's double check in production once this publishes! |
|
Yes, you are depolying now? |
|
I'm trying to fix this first:
#6581/ but
either tonight or tomorrow i hope!
…On Thu, Nov 14, 2019 at 2:36 PM Sagarpreet Chadha ***@***.***> wrote:
Yes, you are depolying now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5678?email_source=notifications&email_token=AAAF6J5W3O63QDRSZYYBIB3QTWSCTA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEDA5HY#issuecomment-554045087>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6JYDZIAUWP7XX5NFKTDQTWSCTANCNFSM4HLMQT4Q>
.
|
|
OK, so the maps on this page all now load properly! https://publiclab.org/wiki/inline-maps But, the markers for each type do not. Looks like a nested bug maybe... @sagarpreet-chadha are you able to take a look at why? |
|
Aha! I'm seeing that maybe there is an initial event trigger that needs to be set up, and that possibly this only fetches markers upon interacting with the map? Not 100% sure, but that seems to work here: https://publiclab.org/wiki/sandbox-3 when you pan or zoom it loads markers! |
|
|
|
Hey @jywarren , In all the API calls,
|
|
Wow, so fast! Awesome.
…On Mon, Nov 18, 2019, 1:25 PM Sagarpreet Chadha ***@***.***> wrote:
Hey @jywarren <https://github.com/jywarren> ,
In all the API calls,
tag | question:infragram is getting added in request URL. Sending a patch
for this now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5678?email_source=notifications&email_token=AAAF6J3TYH6AOM2QHOGQQEDQULMZLA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELNRAQ#issuecomment-555145346>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J2BBIB7564QSCJHMUDQULMZLANCNFSM4HLMQT4Q>
.
|
|
Solved in this PR: #6802 . The trick is to use unique variable names everywhere, i will remember this 😄 !!! Otherwise hard to find this bug if one has no context! |
|
Awesome!!!
…On Mon, Nov 18, 2019 at 2:10 PM Sagarpreet Chadha ***@***.***> wrote:
Solved in this PR: #6802 <#6802>
. The trick is to use unique variable names everywhere, i will remember
this 😄 !!! Otherwise hard to find this bug if one has no context!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5678?email_source=notifications&email_token=AAAF6J5EVW7XNAO5WN3Q6PLQULR7LA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELR76Y#issuecomment-555163643>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J53LNDZEINO36SJ6EDQULR7LANCNFSM4HLMQT4Q>
.
|
|
Nice - fixed and live! https://publiclab.org/wiki/inline-maps |
|
Yes just saw, glad we fixed this :)
Should i add the new LEL inline syntax to this page or make a seperate
wiki? Thanks!
…On Thu, 21 Nov 2019, 09:41 Jeffrey Warren, ***@***.***> wrote:
Nice - fixed and live! https://publiclab.org/wiki/inline-maps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5678?email_source=notifications&email_token=ADSCRRIWZ7DZZQVLEK4OQLTQUYC7FA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEY4XGY#issuecomment-556911515>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADSCRRM4LAJGIIADVM4ANVTQUYC7FANCNFSM4HLMQT4Q>
.
|
|
Let's add it here! Good idea.
On Thu, Nov 21, 2019 at 1:01 AM Sagarpreet Chadha <notifications@github.com>
wrote:
… Yes just saw, glad we fixed this :)
Should i add the new LEL inline syntax to this page or make a seperate
wiki? Thanks!
On Thu, 21 Nov 2019, 09:41 Jeffrey Warren, ***@***.***>
wrote:
> Nice - fixed and live! https://publiclab.org/wiki/inline-maps
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#5678?email_source=notifications&email_token=ADSCRRIWZ7DZZQVLEK4OQLTQUYC7FA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEY4XGY#issuecomment-556911515
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ADSCRRM4LAJGIIADVM4ANVTQUYC7FANCNFSM4HLMQT4Q
>
> .
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#5678?email_source=notifications&email_token=AAAF6J2QEDYEULOBFKSF6LLQUYP2DA5CNFSM4HLMQT42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZCGCI#issuecomment-556933897>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J7QXQURESETZQN7VJ3QUYP2DANCNFSM4HLMQT4Q>
.
|
https://publiclab.org/wiki/inline-maps seems to be stalling and erroring a bit, and I know @sagarpreet-chadha has worked on this before, so I feel bad bringing it up again, but there are some
I see a few things going on which I think is what makes this so complicated.
Also, this error is shown on the page:
I think this really may be multiple overlapping issues here! Maybe once we get it totally working, we should write a system test to protect this, since there's so much JS/Ruby integration going on here: #5316
The text was updated successfully, but these errors were encountered: