Emoji reactions are no longer showing authors

[jywarren]

Hi @ViditChitkara -- i noticed this on comments... maybe due to the refactor?

I'd love some help getting this fixed! And please don't be discouraged by the bugs here, this was a really big refactor so they're bound to happen 😄

One thing we might do now, is to write a system test for some of this, to protect the features! #5316

[ViditChitkara]

Hi @jywarren , that's quite odd. I think this might be a specific case where authors are not showing with the emoji. Oh I think I got it, it shows the authors after refreshing. The reason might be, we are dynamically adding the emoji but, associated js.erb doesn't cater for the tooltip which shows the authors. Is that what might be happening?
Also, could you share the link to the comment in the screenshot above? and yeah I'll be starting with the tests next.
Thanks!

[jywarren]

ah, ok! yes, so i think we can activate it with `$().tooltip('selector')` where the selector is something narrow enough to only affect the newly added HTML? This is in a reply to a comment, i believe on one of the proposals but perhaps you could find it relatively quickly here? https://publiclab.org/comments Thank you!

…

On Tue, Apr 2, 2019 at 1:08 AM Vidit ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren> , that's quite odd. I think this might be a specific case where authors are not showing with the emoji. Oh I think I got it, it shows the authors after refreshing. The reason might be, we are dynamically adding the emoji but, associated js.erb doesn't cater for the tooltip which shows the authors. Is that what might be happening? Also, could you share the link to the comment in the screenshot above? and yeah I'll be starting with the tests next. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5343 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzYCTieq4QMFB5mwY_3zBIkH1P5oks5vcuW6gaJpZM4cW9LH> .

[jainaman224]

@jywarren @ViditChitkara Can I work on this?

[jainaman224]

After https://github.com/publiclab/plots2/blob/master/app/controllers/comment_controller.rb#L209 adding

@user_reactions_map = comment.user_reactions_map

After https://github.com/publiclab/plots2/blob/master/app/views/comments/like_comment.js.erb#L12 adding

<% if @user_reactions_map.has_key? capitalized_emoji_name %>
  $("<%= str %>").attr("data-original-title", "<%= @user_reactions_map[capitalized_emoji_name] %>");
<% end %>

Fixed the issue.

[ViditChitkara]

@jainaman224 that's really cool!! Could you open a PR for this. Thanks!