Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The popover does not close down unless clicked specifically again #4987

Closed
CleverFool77 opened this issue Mar 10, 2019 · 4 comments
Closed

The popover does not close down unless clicked specifically again #4987

CleverFool77 opened this issue Mar 10, 2019 · 4 comments
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) enhancement explains that the issue is to improve upon one of our existing features has-pull-request issues which already have a pull request solving it

Comments

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 10, 2019 •
edited

I found this issue while trying to solve the issue #4985 #4986

Description

The popover opens when tag pill is clicked, but it does not closes down unless clicked specifically again on same pill. If a new tag is added or user clicks on any other thing, it still doesn't close down.

Current Behaviour

Screenshot from 2019-03-10 19-37-59

hh

gg

Expected Behaviour

A popover should close down if the user clicks anywhere on screen. A user should not have need to click on tag pill again to close it.
@grvsachdeva
Copy link
Member

Hi @CleverFool77, you are doing awesome work with all the bug fixes, issues, etc 💯 . How about opening some FTO to welcome new people, as many people are waiting for getting started - #4963?

Thanks!

@grvsachdeva grvsachdeva added enhancement explains that the issue is to improve upon one of our existing features design issue requires more design work and discussion (i.e. mockups and sketches) labels Mar 10, 2019
@CleverFool77
Copy link
Member Author

Sure @gauravano :).

@grvsachdeva
Copy link
Member

Awesome!

@CleverFool77 CleverFool77 mentioned this issue Mar 10, 2019
Closed
5 tasks
@grvsachdeva grvsachdeva added the has-pull-request issues which already have a pull request solving it label Mar 11, 2019
This was referenced Mar 12, 2019
Closed
Closed
Merged
@grvsachdeva
Copy link
Member

closing this. Refer #5072 (comment). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) enhancement explains that the issue is to improve upon one of our existing features has-pull-request issues which already have a pull request solving it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grvsachdeva @CleverFool77