Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Access token modal like Link social modal #4542

Closed
grvsachdeva opened this issue Jan 5, 2019 · 4 comments
Closed

Implement Access token modal like Link social modal #4542

grvsachdeva opened this issue Jan 5, 2019 · 4 comments
Labels
CSS design issue requires more design work and discussion (i.e. mockups and sketches) fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML JavaScript refactorization

Comments

@grvsachdeva
Copy link
Member

link_social_modal

This is social media linking modal which is integrated using simple HTML - https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L206-L223

access_token_modal
This is access token modal which is integrated using JavaScript - https://github.com/publiclab/plots2/blob/master/app/views/users/_token.html.erb which is complicated as token modal can be implemented similar to the social modal.

Make the token modal appear without using the JavaScript code present in file _token.html.erb and implement it just like social media modal i.e., normal bootstrap modal called on button press.

Thanks!

@grvsachdeva grvsachdeva added JavaScript design issue requires more design work and discussion (i.e. mockups and sketches) fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML CSS refactorization labels Jan 5, 2019
@trompj
Copy link
Contributor

trompj commented Jan 7, 2019

Hi @gauravano, I am going to try and work on this for a bit and see if I can get it. It's my first project outside of basic coursework so bear with me!

@trompj
Copy link
Contributor

trompj commented Jan 8, 2019

@gauravano In order to copy to clipboard via the button, the JavaScript is a necessity in some shape or form. I adjusted the code to allow removal of all other JavaScript in the file though. Would you prefer to try and have the copy function in the profile file and remove the token file completely or just leave the copy function by itself in the token file?

@trompj
Copy link
Contributor

trompj commented Jan 8, 2019

@gauravano I went ahead and moved all the scripting to the profile.html.erb file. I can make additional changes as needed! I know there was some css I wanted to look at for mobile devices that needed some updating. I am going to go ahead and push my changes and commit for now.

@grvsachdeva
Copy link
Member Author

Welcome to Public Lab @trompj and happy to see your energy. As you have opened your PR, we can have further discussion there only.

Reviewing your PR now.Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS design issue requires more design work and discussion (i.e. mockups and sketches) fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML JavaScript refactorization
Projects
None yet
Development

No branches or pull requests

2 participants