Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam in email digests? #4480

Closed
oorjitchowdhary opened this issue Dec 31, 2018 · 12 comments
Closed

Spam in email digests? #4480

oorjitchowdhary opened this issue Dec 31, 2018 · 12 comments
Labels
help wanted requires help by anyone willing to contribute more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem Ruby

Comments

@oorjitchowdhary
Copy link
Member

Please describe the problem (or idea)

As per @gauravano in #2104, email digests are not active.
But I'm receiving weekly digests. Moreover, these are STRANGE weekly digests.

The digest uses the template we have made and comes from: notifications@publiclab.org but it is full of ADVERTISEMENTS.

It shows the ads in the form of research notes and even takes up a link on PL.
When clicked on the link, it takes us to publiclab.org and then the website returns a flash message saying the author of this note is banned.

spam in email digest

What happened just before the problem occurred? Or what problem could this idea solve?

screenshot 136

screenshot 137

screenshot 139

screenshot 140

Please show us where to look

Weekly digests

What's your PublicLab.org username?

oorjit_chowdhary

Browser, version, and operating system

Chrome, Windows 10


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@oorjitchowdhary
Copy link
Member Author

@publiclab/reviewers @publiclab/community-reps What's to be done here??

@grvsachdeva grvsachdeva added help wanted requires help by anyone willing to contribute Ruby more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem labels Dec 31, 2018
@grvsachdeva
Copy link
Member

Have you pressed that "Digest button" present in your profile? hmm, email content is really shocking.

@oorjitchowdhary
Copy link
Member Author

oorjitchowdhary commented Dec 31, 2018

Have you pressed that "Digest button" present in your profile?

I don't remember, but I think yes

You mean to say the test digest mail button right?

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

Oh whoa! does this mean somehow that the digest function (which had been broken) is now working?

Perhaps some change we made recently has resolve the blocking issue on that. Let's do 2 things - further test to see why Oorjit is receiving them but nobody else (?)

I just turned on my digest again, daily, so I'll watch for it.

In the meantime, let's track where digest content is collected and exclude nodes with status != 1!

@grvsachdeva
Copy link
Member

I just enabled the digest for myself again by going in "Settings" and then pressing test digest button and received a mail with nice content in it, although date and formatting requires work.

digest_mail

Let's see if it's just due to button press or we get the digest daily such that cron is also doing it's job or not.

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

OK - i enabled it daily now. Let's see. https://publiclab.org/settings

@jywarren
Copy link
Member

jywarren commented Jan 2, 2019

For the status, i just changed it: 8062489

@SidharthBansal @gauravano are we pretty ready to publish stable to production? I know a LOT has changed and wanted to check with you first. Thanks!

@grvsachdeva
Copy link
Member

grvsachdeva commented Jan 2, 2019

Yes from me as I have merged changes which are cross-checked on unstable mostly. But, I guess, we should wait for Sidharth as he has pushed Auth work and can better tell us about the Login/SignUp status.

Thanks!

@jywarren
Copy link
Member

jywarren commented Jan 3, 2019

Continuing to track digest issues here: #3404

I think we can close this, but we should open some new ones for the formatting/images/bio profile pics of the digest!

@jywarren jywarren closed this as completed Jan 3, 2019
@oorjitchowdhary
Copy link
Member Author

@jywarren Can I request one thing... Can you please give me the permissions for adding labels, closing issues etc..
Thank you!

@jywarren
Copy link
Member

jywarren commented Jan 3, 2019

Absolutely!

@oorjitchowdhary
Copy link
Member Author

Thanks a ton.. I'm able to view the new features now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem Ruby
Projects
None yet
Development

No branches or pull requests

3 participants