Improve buttons layout at /profile

[oorjitchowdhary]

Problem

The buttons below tags at /profile are not well formatted and well-aligned.

Code link

plots2/app/views/users/profile.html.erb

Lines 206 to 217 in 58d5ea8

	<a class="btn btn-default btn-sm btn-block" href="/feed/<%= @user.name %>.rss"><i class="fa fa-rss" style="color:orange;"></i> <%= t('users.profile.rss_feed_for') %> <%= @user.name %></a>
	<% if current_user && current_user.uid == @user.uid %>
	<a href="/profile/<%= @user.name %>/edit" class="btn btn-default btn-sm btn-block"><i class="fa fa-pencil"></i> <%= t('users.profile.edit_profile') %></a>
	<% end %>
	</p>
	<% if @profile_user && current_user && @profile_user == current_user %>
	<button id="btn-token" class="btn btn-default btn-block">My Access Token</button>
	<% end %>
	<% if @profile_user && current_user && @profile_user == current_user %>
	<button data-toggle="modal" data-target="#socialModal" class="btn btn-default btn-block">Link Social media</button>

Solution

We can use the same class="btn btn-default btn-block" for all buttons rather than using two classes and for consistency in the design and can also center-align the Test Digest Mail button.

[SidharthBansal]

@oorjitchowdhary we need to hide the Test Digest button from the production. We can use if Rails.env == production ....etc conditions here.
Let's take input from @gauravano for this.

[SidharthBansal]

Thanks for raising the issue. It will be great if you can help the mentors with the pending prs and issues we are tackling. We already have a huge list of 500 issues this time.

[oorjitchowdhary]

Yes.. I saw the huge amount of issues and PRs... I can help the mentors wherever I could be of assistance..

[oorjitchowdhary]

Also, I will try to fix some of the issues which are raised by myself

[SidharthBansal]

Yeah sure. Just you don't need to solve first timers only issues. You can try to solve your existing issues or anyone else's issues which you have claimed. Most of the mentors are busy right now, I can help you with those which I have raised. If you want you can work on them.

…

On Wed, Dec 12, 2018 at 3:04 PM Oorjit Chowdhary ***@***.***> wrote: Also, I will try to fix some of the issues which are raised by myself — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQxEqVEoNHBopcGDZV7IntVUxq8y9ks5u4M2pgaJpZM4ZPC9U> .

[SidharthBansal]

huge amount of issues and PRs.

Ideal number of PRs which we want is less than 30. We want less than 300 issues at the earliest. So, a lot of stuff is pending. Issue and PR tracker has raised a lot. I tried my level best to solve as much as I can and review as much as I can.

[oorjitchowdhary]

Yeah sure. Just you don't need to solve first timers only issues. You can try to solve your existing issues or anyone else's issues which you have claimed. Most of the mentors are busy right now, I can help you with those which I have raised. If you want you can work on them.

Ohk then.. Let's get to work

[oorjitchowdhary]

huge amount of issues and PRs.

Ideal number of PRs which we want is less than 30. We want less than 300 issues at the earliest. So, a lot of stuff is pending. Issue and PR tracker has raised a lot. I tried my level best to solve as much as I can and review as much as I can.

Less than 30 and less than 300, which means we have a lot to cover

[SidharthBansal]

Yeah

…

On Wed, Dec 12, 2018 at 4:32 PM Oorjit Chowdhary ***@***.***> wrote: huge amount of issues and PRs. Ideal number of PRs which we want is less than 30. We want less than 300 issues at the earliest. So, a lot of stuff is pending. Issue and PR tracker has raised a lot. I tried my level best to solve as much as I can and review as much as I can. Less than 30 and less than 300, which means we have a lot to cover — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ2qjbRJ9wsC_KPheRHWgxMoyOWoKks5u4OIzgaJpZM4ZPC9U> .

[oorjitchowdhary]

@SidharthBansal Can I make the changes which can be done now .. and we can add the conditional for the button in a commit.. is that okay?

[IshaGupta18]

Can I take up this issue if it hasn't been assigned already? I want to contribute for the first time. Thank you all!

[SidharthBansal]

@oorjitchowdhary it will be great if you will create a first timer for @IshaGupta18 and help her out through the workflow.

[oorjitchowdhary]

Yes, we could do that.. so would we do the if Rails.env conditional in a new issue?
We were waiting for @gauravano's views

[SidharthBansal]

Can I take up this issue if it hasn't been assigned already?

@IshaGupta18 this is not a first timer only issue. It is intermediate level issue. @oorjitchowdhary is working on it. @oorjitchowdhary will create a first timer issue for you and help you with it.
Thanks both of you

[oorjitchowdhary]

@SidharthBansal I'll break this into two issues -- one for buttons change and one for the rails.env conditional.. I hope this works

[SidharthBansal]

Great

[IshaGupta18]

Okay @SidharthBansal and @oorjitchowdhary. I really appreciate the help.

[oorjitchowdhary]

@IshaGupta18 you can start working on #4285

[SidharthBansal]

Awesome Oorjit

…

On Wed, Dec 12, 2018 at 7:33 PM Oorjit Chowdhary ***@***.***> wrote: @IshaGupta18 <https://github.com/IshaGupta18> you can start working on #4285 <#4285> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ1ztg1d0zr2gwoV7Mc1h_-H8eLDXks5u4Qy_gaJpZM4ZPC9U> .

[oorjitchowdhary]

#4285 and #4286
So, I'm closing this now

[uzorjchibuzor]

I am interested in the test digest button, this issue is closed but I can still see the button production. If it’s available, I would like to take a stab at it