Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make store signup a modal #4190

Closed
jonxuxu opened this issue Dec 8, 2018 · 5 comments
Closed

Make store signup a modal #4190

jonxuxu opened this issue Dec 8, 2018 · 5 comments
Assignees

Comments

@jonxuxu
Copy link
Member

jonxuxu commented Dec 8, 2018

This issue is a continuation of #4132

At https://store.publiclab.org/ , you can see there's a login icon:
image

What we want to do, is to add Oauth to this login pane and turn it into a modal.
image

@digitaldina digitaldina changed the title Make store signup a modal and add Oauth Make store signup a modal Dec 8, 2018
@digitaldina
Copy link
Collaborator

We shouldn't add OAuth, see #4132 (comment)

@SidharthBansal
Copy link
Member

@dinaelhanan comment

@JonathanXu1 so for the store, I'm seeing this as the login:
screenshot from 2018-12-08 12-21-15
Do you mean that we should add Oauth to it?

@oorjitchowdhary's comment

Wow.. that is just a great login page.. We could perhaps make it into a modal, add Oauths to it... And maybe also implement the same design on the publiclab.org login modal..

@SidharthBansal's comment

Wow.. that is just a great login page.. We could perhaps make it into a modal, add Oauths to it...
@oorjitchowdhary ,@dinaelhanan no you need not to do the OAuth for providers on the store. Store is a different website. Its codebase is not available to us.
I think we need not to link the login/sign up modal to that store page.

@SidharthBansal
Copy link
Member

@oorjitchowdhary's comment

Oh i see.. So perhaps we can implement only its design for our login modal?

@dinaelhanan's comment

@JonathanXu1 no I just edited the title, we just have to make it a modal

@SidharthBansal
Copy link
Member

Students, I think that store's codebase is different from the plots2 codebase. So please don't get started with this issue until and unless @jywarren asks us to do that.
Secondly, OAuth is a lengthy project, even if Jeff will agree this store OAuth will not be a part of GCI for sure. It's much broader task for you than you are imagining. I hope you can understand it.

@jywarren
Copy link
Member

Yes, I think this one we can close up, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants