Move comment_render_body helper into Comment model

[jywarren]

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

plots2/app/helpers/application_helper.rb

Lines 100 to 107 in 6595ef3

	# we should move this to the Comment model:
	# returns the comment body which is to be shown in the comments section
	def render_comment_body(comment)
	raw RDiscount.new(
	title_suggestion(comment),
	:autolink
	).to_html
	end

Let's make this a method of Comment - in https://github.com/publiclab/plots2/blob/master/app/models/comment.rb - like:

def render_body

end

And remove it from application_helper.rb!

We'll also need to change this line:

plots2/app/views/notes/_comment.html.erb

Line 120 in 6595ef3

<% comment_body = render_comment_body(comment) %>

To comment.render_body

Finally, the sanitize comment body test in https://github.com/publiclab/plots2/blob/master/test/unit/comment_test.rb could be updated to test comment.render_body instead of reproducing the code from the helper.

Glad to help with this one! Could be a first-timers issue!

[mauricetmeyer]

I would like to take on this issue, it would be one of my first open source contributions. Also is there anything I would need to know before opening a pull request, like a special schema for commit messages?

[jywarren]

Nope, there's a template in the pull request form, but it's always editable later, so we can help you out as you go! Welcome! 👍 🎉

[mauricetmeyer]

@jywarren Thank you! Also those first timer issues are great to get to know the codebase, as I often don't have much time to read into large codebases. 👍

[jywarren]

so glad you like them!!!

…

On Mon, Oct 1, 2018 at 6:09 PM Maurice T. Meyer ***@***.***> wrote: @jywarren <https://github.com/jywarren> Thank you! Also those first timer issues are great to get to know the codebase, as I often don't have much time to read into large codebases. 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3552 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7XhfzVY7CxWNvf58mMmOiKBNZjlks5ugpKSgaJpZM4XCx6-> .