Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profile url on Search profiles view #3386

Closed
5 tasks
stefannibrasil opened this issue Sep 22, 2018 · 4 comments · Fixed by #3389
Closed
5 tasks

Update profile url on Search profiles view #3386

stefannibrasil opened this issue Sep 22, 2018 · 4 comments · Fixed by #3389
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML

Comments

@stefannibrasil
Copy link
Contributor

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the line 10 on this file app/views/search/profiles

See this page for some help in taking your first steps!

Below is a "diff" showing in green (and a +) with line to change, just change "search" with "profile":

<div class="row">
  - <a href= <%= "/search/#{profile.username}" %> ><%= profile.username %></a>
  + <a href= <%= "/profile/#{profile.username}" %> ><%= profile.username %></a>
</div>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@stefannibrasil stefannibrasil added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Sep 22, 2018
@jywarren jywarren added help wanted requires help by anyone willing to contribute HTML and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Sep 22, 2018
@jywarren jywarren added this to the Search improvements milestone Sep 22, 2018
@abhishek71994
Copy link
Contributor

I would like to work on this.

@rbhatia46
Copy link
Member

rbhatia46 commented Sep 22, 2018

I would like to work on this. Can I take this @stefannibrasil ?

@SidharthBansal
Copy link
Member

@abhishek71994 go ahead.
@rbhatia46 try other issues.

@abhishek71994
Copy link
Contributor

#3389

Please check this PR @SidharthBansal @stefannibrasil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants