Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API tagging implementation #2790

Closed
2 of 3 tasks
stefannibrasil opened this issue Jun 8, 2018 · 1 comment · Fixed by #2847
Closed
2 of 3 tasks

API tagging implementation #2790

stefannibrasil opened this issue Jun 8, 2018 · 1 comment · Fixed by #2847
Assignees
Labels
enhancement explains that the issue is to improve upon one of our existing features Ruby

Comments

@stefannibrasil
Copy link
Contributor

stefannibrasil commented Jun 8, 2018

The goal of this Issue is to improve #1934, as discussed in #2755.

We need to include tags in the URL input. This should solve #2254.

Steps

  • Include tags in URL:

    # Request URL should be /api/srch/locations?srchString=QRY[&seq=KEYCOUNT&showCount=NUM_ROWS&pageNum=PAGE_NUM]
    # Note: Query(QRY as above) must have latitude and longitude as srchString=lat,lon

  • Update the nearbyNodes method to also include tags:

    def nearbyNodes(srchString)

  • Update doc/API.md file with the new functionality

@stefannibrasil stefannibrasil added enhancement explains that the issue is to improve upon one of our existing features Ruby labels Jun 8, 2018
@stefannibrasil
Copy link
Contributor Author

stefannibrasil commented Jun 8, 2018

@Gauravano @sagarpreet-chadha @jywarren I've written this Issue to coordinate better our contribution. I am working on this, I just need more time to configure my PC again because I've updated my OS 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features Ruby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant