Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt to create content to inline grids #2624

Closed
5 tasks
first-timers bot opened this issue Apr 16, 2018 · 3 comments · Fixed by #2626
Closed
5 tasks

Add a prompt to create content to inline grids #2624

first-timers bot opened this issue Apr 16, 2018 · 3 comments · Fixed by #2626
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute

Comments

@first-timers
Copy link

first-timers bot commented Apr 16, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Inline grids (documented at https://publiclab.org/wiki/power-tags) allow you to embed a table of content in a wiki page -- like on https://publiclab.org/wiki/basic-microscope, for example (click Edit to see).

This change will show a friendlier message if the grid shows no matching content yet, and prompt the viewer to help get it started.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/grids/_notes.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -21,7 +21,7 @@
   </tr>
 <% if nodes.empty? %>
   <tr>
-    <td>No matching content.</td>
+    <td>Nothing yet on the topic "<b><a href="/tag/<%= tagname %>"><%= tagname %></a></b>" -- be the first to post something!</td>
     <td></td>
     <td></td>
     <td></td>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Apr 16, 2018
@eduardoltorres
Copy link
Contributor

Hey! First timer here. I'm just following the first step by claiming the issue, since I don't see any comment here. Thanks for the opportunity!

@eduardoltorres
Copy link
Contributor

Just finished. I really got confused after I started the pull request. What are the checkboxes about and who has to checked them? Thank you to anyone available to review.

@grvsachdeva
Copy link
Member

grvsachdeva commented Apr 17, 2018

Awesome @eduardoltorres !!! Instructions with checkboxes are there so that one can use them as a checklist to make a good PR. You can check the boxes for sure. Thank you so much for taking this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants