Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect tag feature by page name #2546

Closed
5 tasks
first-timers bot opened this issue Mar 26, 2018 · 3 comments · Fixed by #2548
Closed
5 tasks

Add redirect tag feature by page name #2546

first-timers bot opened this issue Mar 26, 2018 · 3 comments · Fixed by #2548
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute Ruby

Comments

@first-timers
Copy link

first-timers bot commented Mar 26, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

We have a redirect system that uses tags -- read more at https://publiclab.org/wiki/power-tags -- but it requires tags to point at a "node id" like redirect:12345. This is hard to remember and kind of obscure -- so let's make it possible to use a page "slug" as well. Then you could redirect to the page at /wiki/openhour by using redirect:openhour.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/controllers/wiki_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -33,6 +33,14 @@ def show
         flash.now[:warning] = "Only moderators and admins see this page, as it is redirected to <a href='#{Node.find(@node.power_tag('redirect')).path}'>#{Node.find(@node.power_tag('redirect')).title}</a>.
         To remove the redirect, delete the tag beginning with 'redirect:'"
       end
+    elsif @node&.has_power_tag('redirect') && Node.where(slug: @node.power_tag('redirect')).exists?
+      if current_user.nil? || !current_user.can_moderate?
+        redirect_to Node.find_by(slug: @node.power_tag('redirect')).path
+        return
+      elsif current_user.can_moderate?
+        flash.now[:warning] = "Only moderators and admins see this page, as it is redirected to <a href='#{Node.find_by(slug: @node.power_tag('redirect')).path}'>#{Node.find_by(slug: @node.power_tag('redirect')).title}</a>.
+        To remove the redirect, delete the tag beginning with 'redirect:'"
+      end
     end
 
     if @node&.has_power_tag('abtest') && !Node.where(nid: @node.power_tag('abtest')).empty?
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Mar 26, 2018
@jywarren
Copy link
Member

This ought to work -- i'm happy to help out!!!

@jywarren jywarren added the Ruby label Mar 26, 2018
@r0vina
Copy link
Contributor

r0vina commented Mar 27, 2018

I'd like to claim this one.

@sagarpreet-chadha
Copy link
Contributor

Great ! You can work on this :-)

@sagarpreet-chadha sagarpreet-chadha added the has-pull-request issues which already have a pull request solving it label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants