Showing contributors on /contributors/____ pages

[jywarren]

https://publiclab.org/contributors/microplastics says 8 contributors, but below on that page nobody is listed.

The code is here: https://github.com/publiclab/plots2/blob/master/app/views/tag/contributors.html.erb

But it's driven by this controller code:

plots2/app/controllers/tag_controller.rb

Lines 394 to 400 in 5ac9916

	def contributors
	set_sidebar :tags, [params[:id]], note_count: 20
	@tagnames = [params[:id]]
	@tag = Tag.find_by(name: params[:id])
	@note_count = Tag.tagged_node_count(params[:id]) || 0
	@users = Tag.contributors(@tagnames[0])
	end

Any help fixing this would be appreciated!!!

We should also work to add a test to ensure this page gets properly populated. We could do a functional test in this file:

plots2/test/functional/tag_controller_test.rb

Lines 286 to 293 in 5ac9916

	test 'tag contributors' do
	get :contributors, id: Tag.last.name
	assert :success
	assert_not_nil :notes
	assert_not_nil :users
	assert_not_nil :tag
	end

There, we don't really count contributors. We should!

Using assert_equal assigns(:users), 99 (where 99 is the expected number of users)

[jywarren]

I think there may have been a reversion in #2180 which affected @Gauravano's code in #2062:

https://github.com/publiclab/plots2/blob/ca820a87e083ed7aff95e6c903732d2d4fca7949/app/views/tag/_contributors.html.erb

It looks like @noteCount was changed to @note_count and I've reverted that in #2479. I want to add a functional test to ensure these are shown.

[jywarren]

Attempting fix in #2479

[jywarren]

with test at

plots2/test/functional/tag_controller_test.rb

Line 293 in 3e9d33c

assert_select ".users-row", assigns(:users).length