Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT TO CONSIDER] create feature at top of /tags #2110

Closed
ebarry opened this issue Jan 25, 2018 · 8 comments
Closed

[DRAFT TO CONSIDER] create feature at top of /tags #2110

ebarry opened this issue Jan 25, 2018 · 8 comments
Labels
help wanted requires help by anyone willing to contribute HTML Ruby

Comments

@ebarry
Copy link
Member

ebarry commented Jan 25, 2018

Please describe the problem (or idea)

What problem could this idea solve?

Over in #179, I raised the issue of how do we help people subscribe to the right content when there are so many tags compared to the limited number of googlegroups that was easier to choose from. @jywarren suggested that we could create a feature:

Manually choosing a subset of "featured tags" seems like something we could/should do in content, not code. If you have the list of tags, we can make a Feature out of it and display that -- like how we do banners. (this helps us keep the code generalizable so it may be used by non-Public Lab groups in the future, it also makes it easier to change the list of chosen tags without rebooting the server)

This is going to be part of #2104

@ebarry ebarry changed the title [DRAFT TO CONSIDER] suggest tags to subscribe to that match old GoogleGroups [DRAFT TO CONSIDER] create feature at top of /tags Jan 25, 2018
@ryzokuken
Copy link
Member

ryzokuken commented Jan 25, 2018

Hi Liz!
Had been wondering: does "just keeping a list of featured tags that show up at the top of the /tags page" suffice?

@jywarren jywarren added the more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem label Jan 25, 2018
@jywarren
Copy link
Member

We could follow a similar approach to #208 but inserting the feature code at the top of this template:

https://github.com/publiclab/plots2/blob/master/app/views/tag/index.html.erb

with the feature name featured-tags -- and then we can manage that via the features system!

@jywarren jywarren added help wanted requires help by anyone willing to contribute Ruby HTML and removed more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem labels Jan 25, 2018
@ryzokuken
Copy link
Member

@jywarren I'll take a look at both of these. I am new to features and everything, so I'd have to do a little research. Is there some documentation you could point me to?

@jywarren
Copy link
Member

jywarren commented Jan 25, 2018 via email

@ryzokuken
Copy link
Member

That's helpful! I would try to make sense of both of these issues as soon as possible and submit a patch.

@jywarren
Copy link
Member

jywarren commented Jan 25, 2018 via email

@jywarren
Copy link
Member

Just realized there's some documentation here! https://github.com/publiclab/plots2/blob/master/doc/DATA_MODEL.md#nodes

jywarren added a commit that referenced this issue Feb 6, 2018
This change inserts a "feature" fixing #2110 but also cleans up the JavaScript formatting a bit. Relatively simple changes!
@jywarren
Copy link
Member

jywarren commented Feb 6, 2018

Made into a first-timers issue in #2260 !

@jywarren jywarren closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute HTML Ruby
Projects
None yet
Development

No branches or pull requests

3 participants