Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.yml #11460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update en.yml #11460

wants to merge 2 commits into from

Conversation

belfarz
Copy link

@belfarz belfarz commented Oct 10, 2022

Improve text for welcome contribution notice
config/locales/en.yml
Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Oct 10, 2022

@belfarz belfarz mentioned this pull request Oct 11, 2022
5 tasks
Copy link
Author

@belfarz belfarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @TildaDares @jywarren may i request this PR be merged with #11461 Thank you so much

@jywarren
Copy link
Member

If these tests pass, this is ready to merge!

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.83%. Comparing base (5d94500) to head (77fa731).
Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #11460       +/-   ##
===========================================
- Coverage   83.21%    1.83%   -81.38%     
===========================================
  Files          93       93               
  Lines        5772     8655     +2883     
===========================================
- Hits         4803      159     -4644     
- Misses        969     8496     +7527     

see 87 files with indirect coverage changes

moderators</a> and we'll email you when it is published. In the meantime, if
you have more to contribute, feel free to do so."
thank_you_for_contribution: |
<h2>Success! You did it! Hooray!</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry there is an error in YAML parsing starting on this line. YAML format is so strict! 😨

Each space is meaningful and necessary. Can you try to make the spacing consistent, for example on this line:

Suggested change
<h2>Success! You did it! Hooray!</h2>
<h2>Success! You did it! Hooray!</h2>

See how each indent should be 2 spaces?

thank_you_for_contribution: |
<h2>Success! You did it! Hooray!</h2>
<hr>
<p>Thank you so much for contributing open research and being part of our community.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will also need an extra space.

and thanks for your patience while your post is approved by <a href='/wiki/moderation'>community
moderators</a> and we'll email you when it is published. In the meantime, if
you have more to contribute, feel free to do so."
thank_you_for_contribution: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that there may need to be only one space before the | character here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i replace the lines in red with the lines in green or should i just fix the spacing

@codeclimate
Copy link

codeclimate bot commented Oct 16, 2022

Code Climate has analyzed commit 77fa731 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Author

@belfarz belfarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for replying late i was a little busy with school project i have updated the spacing and made it consistent please feel free to correct me if there is any more mistake as i would correct it as soon as possible

Copy link

stale bot commented Apr 22, 2024

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants