Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code alignment and update indentation from tabs to double-spaces within script tag in _range.html.erb #11006

Closed
5 tasks
simransia opened this issue Apr 9, 2022 · 26 comments · Fixed by #11159
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@simransia
Copy link
Contributor

simransia commented Apr 9, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

 var options = {
-    chart: {
-        type: 'bar',
-        height: 130,
-        width: '90%',
-        stacked: true,
-        stackType: '100%'
-        },
+  chart: {
+    type: 'bar',
+    height: 130,
+    width: '90%',
+    stacked: true,
+    stackType: '100%'
+  },
-    plotOptions: {
-        bar: {
-            horizontal: true,
-        },
-     },
+  plotOptions: {
+    bar: {
+      horizontal: true,
+    },
+  },
-    stroke: {
-        width: 1,
-        colors: ['#fff']
-  },
-    series: [{
-        name: 'Questions asked',
-        data: questions
-    },{
-        name: 'Questions answered',
-        data: answers
-    }],
+  stroke: {
+    width: 1,
+    colors: ['#fff']
+  },
+  series: [{
+    name: 'Questions asked',
+    data: questions
+  },{
+    name: 'Questions answered',
+    data: answers
+  }],
-        fill: {
-            opacity: 1
-        },
-        title: {
-            text: "Questions asked vs Answered in this period",
-        },
-
-        legend: {
-            show: false,
-        },
-        grid: {
-            show: false,
-        },
-        xaxis: {
-            labels: {
-                show: false,
-            },
-            axisBorder: {
-                show: false
-            },
-            lines: {
-                show: false,
-            }
-        },
-        yaxis: {
-            labels: {
-                show: false,
-            }
-        }
+  fill: {
+    opacity: 1
+  },
+  title: {
+    text: "Questions asked vs Answered in this period",
+  },
+
+  legend: {
+    show: false,
+  },
+  grid: {
+    show: false,
+  },
+  xaxis: {
+    labels: {
+      show: false,
+    },
+    axisBorder: {
+      show: false

+    lines: {
+      show: false,
+    }
+  },
+  yaxis: {
+    labels: {
+      show: false,
+    }
+  }
 
 }
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@simransia simransia added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Apr 9, 2022
@welcome
Copy link

welcome bot commented Apr 9, 2022

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@simransia
Copy link
Contributor Author

Hello @TildaDares @cesswairimu @jywarren . Please go through this issue and check if this issue is eligible for becoming an FTO issue for new contributors.

Thank You❤️

@TildaDares
Copy link
Member

Thanks for opening this issue @simransia. I took a look at the file but I don’t see any indentation problems.

@simransia
Copy link
Contributor Author

Yes mam, my apologies. There is no need for fixing indentation in that file. Actually in vs code the file was not looking properly formatted, so I had created the issue.

I have updated this issue, please review it again @TildaDares.

Thankyou

@simransia simransia changed the title Format code by improving the indentation in blog.css stylesheet improve code formatting by fixing indentation in _range.html.erb Apr 9, 2022
@TildaDares
Copy link
Member

Hi @simransia, indentations are supposed to be two spaces deep.

@simransia
Copy link
Contributor Author

Hello @TildaDares , I have again made some corrections related to indentation. I think now it is up to the expectation.
Please review it.

Thank You 💛

@simransia simransia changed the title improve code formatting by fixing indentation in _range.html.erb Improve code alignment and update indentation from tabs to double-spaces within script tag in _range.html.erb Apr 11, 2022
@TildaDares
Copy link
Member

This looks great @simransia. Thank you!!

@TildaDares
Copy link
Member

Reserved for @anirudh-t-d for 24 hours!!

@TildaDares TildaDares added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Apr 11, 2022
@anirudh-t-d
Copy link

Hi @TildaDares thank you for assigning an fto to me!!! I will work on this ASAP

@rajvidg
Copy link
Contributor

rajvidg commented Apr 15, 2022

@simransia @TildaDares is this issue still open or assigned to someone, please let me know, I would like to help if possible.

@AmineZCS
Copy link

@anirudh-t-d @TildaDares @rajvidg is this issue still open? I would like to make my first contribute

@anirudh-t-d
Copy link

I am working on it.

@TildaDares
Copy link
Member

HI @anirudh-t-d, do you need help with this?

@anirudh-t-d
Copy link

Sorry mam. I couldn't get time to devote on this as I was on a medical emergency. I will complete it by Saturday. Apologies again for this

@TildaDares
Copy link
Member

Hi @anirudh-t-d, please take all the time you need. Thank you!

@nawed2611
Copy link

Hey! Is this issue still open?

@TildaDares
Copy link
Member

Hi @nawed2611, someone’s working on this issue. You can leave a comment in #11105 and we’ll look for an issue for you. Thanks!!

@TildaDares
Copy link
Member

Hi @anirudh-t-d, any updates?

@anirudh-t-d
Copy link

Hi @TildaDares can you please review my pull request if everything is okay?

@TildaDares
Copy link
Member

Hi @anirudh-t-d, I can't find your PR.

@anirudh-t-d
Copy link

Hi @TildaDares anirudh-t-d#1 I think this is it

@TildaDares
Copy link
Member

Hi @anirudh-t-d, you need to make a PR in publiclab/plots2.

@anirudh-t-d
Copy link

Okay. I will work on that

@TildaDares
Copy link
Member

Reassigning

@TildaDares
Copy link
Member

Reserved for @stirlhoss for 24 hours!

@stirlhoss
Copy link
Contributor

@TildaDares PR submitted, ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
7 participants