Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on re-checking "blur my location" box, red square malfunctions #112

Closed
jywarren opened this issue Feb 15, 2018 · 7 comments
Closed

on re-checking "blur my location" box, red square malfunctions #112

jywarren opened this issue Feb 15, 2018 · 7 comments

Comments

@jywarren
Copy link
Member

(reposting on behalf of @ebarry from publiclab/plots2#2243)

Please describe the problem

What happened just before the problem occurred?

This is a bug related to Geographic Features publiclab/plots2#1416

I used the "Link with location" feature:

  • I navigated to the location i was interested in
  • i browsed with the default of "blur my location"
  • i unchecked "blue my location"
  • i re-checked the default "blur my location -- and that's when the problem occurred: the red square got stuck on the spot where i had "unblurred" my location, and did not reset despite panning it off the screen or zooming in or out. See here:

location-bug

What did you expect to see that you didn't?

I expected to have the "link to location" interface return to its default "blur my location" functionality during which the red square updates depending on how the map was panned underneath it. The red square is always pinned in the center of the map, even as the map is panned underneath.

Please show us where to look

https://publiclab.org/notes/gwirth/07-01-2014/preliminary-stitch-of-dredge-island-planting-day-in-jamaica-bay

What's your PublicLab.org username?

This can help us diagnose the issue:

liz

@sagarpreet-chadha
Copy link
Collaborator

Hi @jywarren , @ebarry 😄 !
I would like to work on it . Thanks !

sagarpreet-chadha added a commit to sagarpreet-chadha/leaflet-blurred-location that referenced this issue Feb 21, 2018
on re-checking "blur my location" box, red square malfunctions publiclab#112
jywarren pushed a commit that referenced this issue Feb 23, 2018
#112  (#114)

* first

* solved first issue

* src directory changed

* deleted package-lock.json

* changes
@mridulnagpal
Copy link
Member

@jywarren @sagarpreet-chadha Got the bug, posted a PR for the same, please have a look!!

@sagarpreet-chadha
Copy link
Collaborator

Hi @mridulnagpal !

I think this issue is resolved in #114 .
Sorry about that , I should have linked that PR to this issue .

@mridulnagpal
Copy link
Member

mridulnagpal commented Feb 28, 2018

Awesome!! Please link all the PR's to issues from now on :)

@mridulnagpal
Copy link
Member

@jywarren Should we close the issue for now then?

@mridulnagpal
Copy link
Member

@jywarren Is this done?

@jywarren
Copy link
Member Author

Yes! Thanks!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants