Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automatic issue raising? #312

Open
tfardet opened this issue May 13, 2024 · 4 comments
Open

Improve automatic issue raising? #312

tfardet opened this issue May 13, 2024 · 4 comments

Comments

@tfardet
Copy link

tfardet commented May 13, 2024

The automatic issue on feed fails seems to be generating a lot of issues which, as far as I can tell, are just temporary issues that do not require any action (please correct me if I'm wrong).

Would it be possible to improve this part to reduce spaminess?
Potential improvements I have in mind could be:

  • caching the fails and raising the issue only after X fails
  • mentioning only the maintainer of the failing feed
@jbruechert
Copy link
Collaborator

I'd recommend splitting up the json file in case you are mentioned to often for feeds you didn't add.

per-feed maintainer info seems a bit too verbose to me.

The first point definitely makes sense, but is more work than it might seem. We currently don't preserve anything about the failures between runs apart from the GitHub issues.

@tfardet
Copy link
Author

tfardet commented May 13, 2024

OK, thanks for the information.
Is there a standard for splitting the json in terms of naming conventions?
I.e. if it's {country}-{something}, is there a rule for what "something" should be ?

@jbruechert
Copy link
Collaborator

If your feed applies for some specific district, you can append the appriviation of its name.
We aren' t currently following any standard there.

@Pi-Cla
Copy link
Contributor

Pi-Cla commented May 18, 2024

No one has to follow any sort of standard when naming a file but so far everyone has followed ISO 3166-2 codes which include the subdivisions when you click on the name of the code.

For example, for France these would be the subdivision codes: https://en.wikipedia.org/wiki/ISO_3166-2:FR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants