Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify cancelled departures/arrivals #31

Closed
wants to merge 4 commits into from
Closed

specify cancelled departures/arrivals #31

wants to merge 4 commits into from

Conversation

derhuerst
Copy link
Member

closes #27

@juliuste juliuste self-requested a review March 17, 2018 11:42
juliuste
juliuste reviewed Mar 17, 2018
View reviewed changes
Copy link
Member

@juliuste juliuste left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to respond, please note my latest comment on the original issue.

@derhuerst derhuerst mentioned this pull request Mar 17, 2018
Open
@juliuste
Copy link
Member

juliuste commented Mar 17, 2018 •
edited

canceled should be required, right? Everything else LGTM.

@derhuerst
Copy link
Member Author

Should it? For now, I've only assigned it if the trips is actually canceled. Don't you think this is sufficient? Is making canceled required worth raising the barrier to use FPTF by a little?

@juliuste
Copy link
Member

You're right, since this is about fptf@1 and it would be a breaking change, making it required here doesn't make sense. For fptf@2 we agreed that it should be required.

@derhuerst
Copy link
Member Author

derhuerst commented Mar 19, 2018 •
edited

Note: This is actually a breaking change and should be PRed against next, also because it expects that departure/arrival may be null.

@derhuerst derhuerst closed this Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliuste juliuste juliuste left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

canceled trips & departures/arrivals
2 participants
@derhuerst @juliuste