Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvement to set_ask #292

Open
Art3miX opened this issue Jun 15, 2023 · 0 comments
Open

minor improvement to set_ask #292

Art3miX opened this issue Jun 15, 2023 · 0 comments
Assignees

Comments

@Art3miX
Copy link

Art3miX commented Jun 15, 2023

Hey team,

In set_ask you query for approvals: https://github.com/public-awesome/marketplace/blob/main/contracts/marketplace/src/execute.rs#LL316C1-L322C1

But owner_of already return list of approvals: https://github.com/public-awesome/marketplace/blob/main/contracts/marketplace/src/execute.rs#LL1262C1-L1275C2

1 query can be reduced here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants