Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT peer-to-peer swaps #217

Closed
shanev opened this issue May 24, 2022 · 6 comments
Closed

NFT peer-to-peer swaps #217

shanev opened this issue May 24, 2022 · 6 comments

Comments

@shanev
Copy link
Member

shanev commented May 24, 2022

No description provided.

@jhernandezb
Copy link
Member

Should this have a small swap fee?

@shanev
Copy link
Member Author

shanev commented May 26, 2022

I think it should have a very small fixed fee since the protocol is facilitating the swap.

@josefleventon josefleventon self-assigned this May 26, 2022
@josefleventon josefleventon removed their assignment Jun 23, 2022
@josefleventon
Copy link

This is currently being built by a third party.
Will update this issue with their progress.

@yubrew
Copy link
Contributor

yubrew commented Jul 29, 2022

@josefleventon it's been a month now, is this still getting built out? who is the 3rd party?

@josefleventon
Copy link

Maurits Bos, he's starting work on it. @MbBrainz on Twitter; he's a newly hired smart contract engineer @ Osmosis.

@MbBrainz
Copy link

Yes please check out the repo, https://github.com/MbBrainz/p2p-nft-trade . I started off with the marketplace contract and It's still starting phase. I had some trouble with defining proper function naming for tje p2p functionality, so if you guys have suggestions please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants