Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment replication with Firebase Storage #5766

Closed
FathiGuemri opened this issue Mar 13, 2024 · 3 comments
Closed

Attachment replication with Firebase Storage #5766

FathiGuemri opened this issue Mar 13, 2024 · 3 comments
Labels

Comments

@FathiGuemri
Copy link
Contributor

After confirming that RxDB does not support attachment replication with Firebase Storage, I set up a manual method to enable it. However, suddenly RxDB supports attachment replication, but only within the same database, which is somewhat good. However, it will affect the database size and its cost significantly for Firestore.

Is there a plan in the future to enable attachment replication with Firebase Storage and others like Amazon S3, Google Cloud Storage, Microsoft Azure Blob Storage...?

I expect it to be quite simple. Instead of storing attachments in the database, they can be uploaded to Firebase Storage.

I tried to create a pull request on the repository to enable this, but honestly, I'm new to replication protocol and lack understanding of the code. However, this my suggestion:

Add new option attachmentWithFirebaseStorage to the SyncOptionsFirestore type:

export type SyncOptionsFirestore = Omit< ReplicationOptions, 'pull' | 'push' > & { firestore: FirestoreOptions; attachmentWithFirebaseStorage: FirebaseStorage; // this new option serverTimestampField?: string; pull?: FirestoreSyncPullOptions; push?: FirestoreSyncPushOptions; }; `
@pubkey
Copy link
Owner

pubkey commented Mar 16, 2024

Hi @FathiGuemri
Your proposal looks good, PR is welcomed.

Copy link

stale bot commented Mar 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem. Notice that only bugs in the rxdb premium plugins are ensured to be fixed by the maintainer. Everything else is expected to be fixed by the community, likely you must fix it by yourself.

@stale stale bot added the stale label Mar 30, 2024
Copy link

stale bot commented Apr 29, 2024

Issues are autoclosed after some time. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem.

@stale stale bot closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants