Skip to content

Docker usage/explanation/example #39

Open
SeanPesce opened this issue Jan 5, 2022 · 1 comment
Open

Docker usage/explanation/example #39

SeanPesce opened this issue Jan 5, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@SeanPesce
Copy link

SeanPesce commented Jan 5, 2022

This project is awesome! I'd like to do some libflutter.so patching myself, but I'm not sure what the correct procedure is.

I've got the Docker container set up, and it seems like the code I want to edit is in /customEngine, but it's unclear to me how to proceed. Is there an explanation of your original patching technique (for dumping the Dart classes, etc.)? Or are there any plans to expand the Docker usage explanation?

Edit: So apparently the Docker container automatically builds libflutter after the wait time specified in the docker run command. The resulting libflutter builds will be in the directory (on the host machine) where you ran docker run.

@Impact-I
Copy link
Contributor

Impact-I commented Jan 16, 2022

Hi @SeanPesce ,
Thank you for your interest in the project.

Yes, I need to add a detailed description to the use of Docker. I'll try to do it soon.
To understand how Docker works, I recommend that you read https://github.com/ptswarm/reFlutter/blob/main/.github/workflows/main.yml

In cutomEngine you make your "patches" on top of those made by reFlutter. Sometimes patches won't get made, you'll need to make them manually. (ex. debug build)
For example, if reFlutter doesn't find a commit in the table for the hash you specified, then it won't make changes. In this case, do it manually starting from here https://github.com/ptswarm/reFlutter/blob/main/src/__init__.py#L190
Set an estimated time. How long will it take you to make edits?
The output will be .so files.

@Impact-I Impact-I added the documentation Improvements or additions to documentation label Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants