Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fine grained Personal Access Tokens (PAT v2) #469

Open
rahim opened this issue Feb 15, 2023 · 2 comments
Open

Support for fine grained Personal Access Tokens (PAT v2) #469

rahim opened this issue Feb 15, 2023 · 2 comments

Comments

@rahim
Copy link

rahim commented Feb 15, 2023

See https://github.blog/2022-10-18-introducing-fine-grained-personal-access-tokens-for-github/

At the time of writing Github are still working on GraphQL support for the newer fine grained access tokens which is likely to be a significant obstacle until resolved. Even github-cli support is blocked by this.

I'm working within an organisation that's already moving to retire use of classic tokens.

Fine grained tokens (with appropriate guidance for end users as to what permissions are needed) seems like a good fit for Trailer. My understanding is its behaviour is entirely read-only, so tokens could be much more narrowly scoped than today.

@ptsochantaris
Copy link
Owner

Hi @rahim and sorry for my very late response. I’m slowly starting to catch up with the backlog of Trailer issues recently.

You make a good point, but I wanted to ask, especially since clearly you’ve given this a lot of thought, if it just makes more sense to simply migrate the app to use an OAuth verification flow, so that users can login using their credentials to each server, and Trailer can handle requesting the appropriate permissions.

Would this cover your use case as well, or is there something intrinsic in these access tokens that would justify specifically supporting them?

@rahim
Copy link
Author

rahim commented Aug 14, 2023

Hi @ptsochantaris, I'd forgotten I'd submitted this.

You make a good point, but I wanted to ask, especially since clearly you’ve given this a lot of thought, if it just makes more sense to simply migrate the app to use an OAuth verification flow, so that users can login using their credentials to each server, and Trailer can handle requesting the appropriate permissions.

Would this cover your use case as well, or is there something intrinsic in these access tokens that would justify specifically supporting them?

If the OAuth route also provides access to all the required APIs it's probably a better choice, I think I started from a place that the app was using a PAT and so would continue to.

In my particular case it's unclear what the difference in approval and admin would look like - I'm not sure what controls organization adminstistrators have to restrict OAuth apps behind approval. I'm assuming (perhaps incorrectly) that an end user can create a PAT for anything they have permission to do themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants