Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still lets you have console access after changing account password or deleting your account #5013

Open
3 tasks done
CodesterDubs opened this issue Feb 23, 2024 · 7 comments
Open
3 tasks done
Labels
not confirmed Report seems plausible but requires additional testing or 3rd part confirmation.

Comments

@CodesterDubs
Copy link

CodesterDubs commented Feb 23, 2024

Current Behavior

I changed my panel user account password from another browser on Account B. I was on console with Account A and if I don't refresh the page, I can still send console commands until I refresh the page. The same thing happens if I delete Account A while on console.

Expected Behavior

It should log you out of the panel as soon as your password is changed or account deleted without having to refresh the page.

Steps to Reproduce

Have two accounts and two browsers. On one account, open console of a running server. On the other account, go to the users admin page and change the password or delete the account. The other account will still have access to send commands in the console of the server.

Panel Version

1.11.5

Wings Version

1.11.8

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
@CodesterDubs CodesterDubs added the not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. label Feb 23, 2024
@notAreYouScared
Copy link
Contributor

When the token rotates, it should invalidate.

@CodesterDubs
Copy link
Author

When the token rotates, it should invalidate.

That's what I would think it should do. See the recording attatched.
https://medal.tv/games/minecraft/clips/1XgjCncf2YdTej/d1337AWBNdvV?invite=cr-MSxzb1YsMTc1MDg3NzMxLA

@Sharktheone
Copy link

The token only rotates every 10-15 minutes. When it expires / is about to expire, the panel needs to send auth details of the user. When you reload the page this happens immediately, you can see this when you have multiple tabs open and only reload one of those.

@cmrxnn
Copy link
Contributor

cmrxnn commented Feb 27, 2024

Seems like a pretty major flaw, especially as people may sometimes reset a password or delete an account in order to immediately stop access to systems. Does the console still work when the user is deleted? Or is it just password updates?

@CodesterDubs
Copy link
Author

Seems like a pretty major flaw, especially as people may sometimes reset a password or delete an account in order to immediately stop access to systems. Does the console still work when the user is deleted? Or is it just password updates?

It still works when the account is deleted

@cmrxnn
Copy link
Contributor

cmrxnn commented Mar 4, 2024

Why aren't sessions invalidated / tokens regenerated upon account deletion? Seems like the obvious thing to do

@CodesterDubs
Copy link
Author

Yeah that's what I would have thought too but apparently not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not confirmed Report seems plausible but requires additional testing or 3rd part confirmation.
Projects
None yet
Development

No branches or pull requests

4 participants