Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] What happens if job dies between push commands? #6

Open
jernsting opened this issue Jun 13, 2022 · 1 comment
Open

[Question] What happens if job dies between push commands? #6

jernsting opened this issue Jun 13, 2022 · 1 comment

Comments

@jernsting
Copy link

Taken from the processing scripts:

# push result file content first - does not need a lock, no interaction with Git
datalad push --to output-storage
# and the output branch next - needs a lock to prevent concurrency issues
flock --verbose $DSLOCKFILE git push outputstore

This makes totally sense, but what happens if the datalad push is successful and the job dies (e.g. due to time limit) before the git push command is executed?

@adswa
Copy link
Collaborator

adswa commented Jul 31, 2022

Sorry for the late response! The data will be pushed and in the output store, but there won't be any Git information about it or its generation, and also no branch that could be merged in the end. As the latter push is at least as important, it wouldn't be good if the job dies in between, the data would essentially be dangling disconnected. However, unless the lock takes unusually long to acquire, the git push operation is typically done very fast afterwards, as it also shouldn't take much time to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants