-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time tracking API updates #13
Comments
This one tripped me up and made me thing in general, how to pass path vs query elements to requests. This is the Time Tracking 2.0 / Get time entries within a date range example:
We have The R code had this before: cu_get_time_entries_within_date_range <- function(team_id, start_date, end_date, assignee) {...} But now making Should we do this instead? Pass all query params as a list? cu_get_time_entries_within_date_range <- function(team_id, params = list()) {...} This lends itself nicely to passing the list on to This, however, brings up a more general question about following this pattern for the rest of the functions, or at least trial it for the Time Tracking API. As long as these params are optional, this should be fine. The problem could be if some of the params are required -- which we'll have to investigate. @krlmlr what do you think? |
Thanks. I don't understand the purpose of the
|
As I understand, the The description is bit vague, but it says that I will stick with arguments for now and find a reasonable lower case alternative (like |
https://clickup.canny.io/feature-requests/p/get-time-entries-by-task-id-from-api
The text was updated successfully, but these errors were encountered: