Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OAuth2 Authorization Code Flow #251

Open
hkusulja opened this issue Jan 13, 2022 · 3 comments
Open

Support for OAuth2 Authorization Code Flow #251

hkusulja opened this issue Jan 13, 2022 · 3 comments

Comments

@hkusulja
Copy link

As per Azure AD App update and support, to increase security, please support new "Authorization Code Flow" with PKCE and CORS instead of the current "Implicit flow".
Meaning also, in Azure AD App registration > Authentication setting - migrate from "Web" to "Single-page application" redirect URIs.
https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-app-types#single-page-apps-javascript.

@psignoret
Copy link
Owner

This plugin already implements the Authorization Code Flow, and does not implement the Implicit flow.

@hkusulja
Copy link
Author

Oh, my bad then, thank you for the update, please confirm that we can safely move Azure AD Authentication from "Web" to "Single-page application" inside Azure AD portal. Thank you

@psignoret
Copy link
Owner

No, if you remove the redirect URL from "Web", the plugin will break. This is not a single-page application, so configuring the redirect URL like that would be inappropriate (and it would not work).

I've opened issue #252 to track adding support for PKCE, but the redirect URL would still be "web".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants