Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store hashed password in json files #239

Open
datze opened this issue Sep 10, 2022 · 1 comment
Open

Store hashed password in json files #239

datze opened this issue Sep 10, 2022 · 1 comment

Comments

@datze
Copy link

datze commented Sep 10, 2022

Wouldn't it be better to store the passwords in the json files not as plain-text but hashed?
(eg "password": "14758f1afd44c09b7992073ccf00b43d", instead of "password": "foobar",)

If the JSON files get lost and the passwords are used for other services on the same machine (yes, not good!), they could be attacked.

@psi-4ward
Copy link
Owner

Valid. Would you prepare a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants