You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempting to get e.g. http://.example.com results in a UnicodeError. It seems like the intention so far has been to raise InvalidUrl instead (see e.g. this line).
I see there was some hesitation in fixing a similar issue (#4168) and would like to add that even catching the error just to rethrow as a requests exception would be beneficial.
Expected Result
Based on PR #774: InvalidUrl: URL has an invalid label.
Actual Result
UnicodeError: encoding with 'idna' codec failed (UnicodeError: label empty or too long)
Attempting to get e.g.
http://.example.com
results in aUnicodeError
. It seems like the intention so far has been to raiseInvalidUrl
instead (see e.g. this line).I see there was some hesitation in fixing a similar issue (#4168) and would like to add that even catching the error just to rethrow as a requests exception would be beneficial.
Expected Result
Based on PR #774:
InvalidUrl: URL has an invalid label.
Actual Result
UnicodeError: encoding with 'idna' codec failed (UnicodeError: label empty or too long)
Reproduction Steps
System Information
The text was updated successfully, but these errors were encountered: