Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAE and ChunkedEncodingError, working patch. #3187

Closed
cnicodeme opened this issue May 12, 2016 · 3 comments
Closed

GAE and ChunkedEncodingError, working patch. #3187

cnicodeme opened this issue May 12, 2016 · 3 comments

Comments

@cnicodeme
Copy link

Hey everyone,

sorry for my intervention here, "out of the blue". I tried to understand if this issue was already discussed (but could find them) so I come here with the situation and trying to understand the solution.

The problem is the following (from what I understood) : Google App Engine, replace the implementation of urlfetch by their own, which contains some changes that breaks urllib3 and subsequently Requests.

@agfor made a fix that seems to work (I didn't had any ChunkedEncodingError since I place the patch on line) and, from my understanding, doesn't break the others users, those that don't use GAE.

I didn't saw his patch as submitted here (I'm wondering why) and I don't know why this hasn't been taken into consideration here. (Please note those are real question, not critics/remarks, my intentions are good :) ).

Hence my post :)

@Lukasa
Copy link
Member

Lukasa commented May 12, 2016

@cnicodeme The requests project does not consider GAE formally supported. Put another way, we don't have any special-case code in requests to use GAE properly. The recommended method of using GoogleAppEngine with requests is to use the requests-toolbelt AppEngineAdapter.

@Lukasa Lukasa closed this as completed May 12, 2016
@cnicodeme
Copy link
Author

Ok that explains all my questions, thank you !

(and wow, you're fast!)

@Lukasa
Copy link
Member

Lukasa commented May 12, 2016

My pleasure!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants