Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supported proxy scheme socks5 #2156

Closed
eromoe opened this issue Aug 1, 2014 · 3 comments
Closed

Not supported proxy scheme socks5 #2156

eromoe opened this issue Aug 1, 2014 · 3 comments

Comments

@eromoe
Copy link

eromoe commented Aug 1, 2014

I see https://github.com/kennethreitz/requests/pull/478 is closed, but why I can not use socks5 proxy?

define as:
PROXIES = { "http": "socks5://127.0.0.1:7070", "https": "socks5://127.0.0.1:7070", }

I use above proxy , and requests raise error Not supported proxy scheme socks5

@Lukasa
Copy link
Member

Lukasa commented Aug 1, 2014

The error is perfectly clear. We do not support SOCKS5 proxies at this time. If you'd read #478 more closely you'd have seen this comment I made:

We currently do not have SOCKS proxy support, we're waiting for that code to be included in urllib3. There are plans afoot for this, but no definitive schedule at this time.

This remains true.

@zed
Copy link

zed commented Nov 29, 2015

urllib3 is an implementation detail.

If the issue is not fixed; it should not be closed unless the answer is that requests will never support SOCKS5 proxies.

@Lukasa
Copy link
Member

Lukasa commented Nov 29, 2015

The fact that urllib3 is an implementation detail is relevant for our features. For features we don't have, implementation is critical. For example, httplib is an implementation detail but it's also why we don't have Twisted support.

I was not blaming urllib3, I was providing a path to get this feature.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants