feat: parsed options #1256
Merged
feat: parsed options #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option parsing. Repeated options are preserved as well as repeated fields within nested options. Parsed options are kept in a parsedOptions field on every level (message, field etc.)
This was referenced Jun 24, 2019
|
Thanks @eyalpost! We'll take a look soon :) |
|
Any news? We'd really like to see this being merged |
This was referenced Sep 20, 2019
|
This PR solves a problem of ours using the grps.gateway.protoc_gen_swagger_options_openapiv2_schema annotation for required fields, so we would also like to see this being merged as soon as possible. |
|
any updates on this? |
mavrick
approved these changes
Dec 7, 2019
|
Any Update? |
ghost
approved these changes
Feb 7, 2020
|
🎉 changes approved!! Can we please merge and cut a release 🙏 BloomRPC will benefit hugely on this |
|
@alexander-fenster any updates on this? |
|
any updates? |
|
hi, is there a plan on accepting this pr? |
|
I merged in the latest master and made sure the tests pass. We'll review the code changes on our next review meeting. |
alexander-fenster
approved these changes
Jul 10, 2020
taylorcode
pushed a commit
to taylorcode/protobuf.js
that referenced
this pull request
Oct 16, 2020
* Add option parsing tests to ensure no regressions are caused * Properly parse option values into objects in addition to the regular option parsing. Repeated options are preserved as well as repeated fields within nested options. Parsed options are kept in a parsedOptions field on every level (message, field etc.) * fix: bad merge * fix: lint * fix: lint * fix: lint * fix: lint * fix: lint * fix: build types Co-authored-by: Alexander Fenster <fenster@google.com> Co-authored-by: Alexander Fenster <github@fenster.name>
This was referenced Oct 18, 2021
This was referenced May 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly parse option values into objects in addition to the regular option parsing.
Repeated options are preserved as well as repeated fields within nested options.
Parsed options are kept in a
parsedOptionsfield on every level (message, field etc.)