New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests_solutions: Tests calls step with illegal action #12

Open

DominikRoB opened this issue May 15, 2022 · 0 comments

DominikRoB commented May 15, 2022

Still investigating the legal and illegal actions.. (:

I noticed that the following code in test_solutions.py does not check for illegal actions:

            if no_op and not done:
                self.assertTrue(len(env.next_time_step) > 0, "step {}".format(step_nb))
                previous_time_step = env.current_time_step
                state, reward, done, _ = env.step(env.jobs)
                self.assertTrue(env.current_time_step > previous_time_step, "we increase the time step")

But sometimes the nope-action is not legal when getting used.

Not sure if its an issue with the test design or if there is a risk that the agent can't reproduce the solutions on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment