Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-kube-stack] Prometheus prometheusConfigReloader hardcoded resources #3152

Open
Demonsthere opened this issue Mar 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Demonsthere
Copy link

Demonsthere commented Mar 24, 2023

Describe the bug a clear and concise description of what the bug is.

This single component of prometheus has hardcoded resource options, including limits: https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L2201-L2208
Because of this it is not possible to override the default values and remove the limits.

Please make it cojsisent with the rest of the chart and remove the default values, so that the users can specify their own :)

Original bug/issue: helm/helm#5184

What's your helm version?

3.11.1

What's your kubectl version?

1.26.2

Which chart?

prometheus-kube-stack

What's the chart version?

master

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helm install --namespace observability --version 44.2.0 prometheus prometheus-community/kube-prometheus-stack -f prometheus-values.yaml --dry-run --debug | subl
install.go:194: [debug] Original chart version: "44.2.0"

install.go:213: [debug] WARNING: This chart or one of its subcharts contains CRDs. Rendering may fail or contain inaccuracies.
Error: INSTALLATION FAILED: template: kube-prometheus-stack/templates/prometheus-operator/deployment.yaml:88:52: executing "kube-prometheus-stack/templates/prometheus-operator/deployment.yaml" at <.Values.prometheusOperator.prometheusConfigReloader.resources.limits.cpu>: nil pointer evaluating interface {}.cpu
helm.go:84: [debug] template: kube-prometheus-stack/templates/prometheus-operator/deployment.yaml:88:52: executing "kube-prometheus-stack/templates/prometheus-operator/deployment.yaml" at <.Values.prometheusOperator.prometheusConfigReloader.resources.limits.cpu>: nil pointer evaluating interface {}.cpu
INSTALLATION FAILED
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:141
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.6.1/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.6.1/command.go:1044
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.6.1/command.go:968
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
	runtime/proc.go:250
runtime.goexit
	runtime/asm_arm64.s:1172

It is not possible to override the default values using {} or null 😞

Anything else we need to know?

No response

@Demonsthere Demonsthere added the bug Something isn't working label Mar 24, 2023
@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@Demonsthere
Copy link
Author

bump for interest

@stale stale bot removed the lifecycle/stale label Apr 26, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@Demonsthere
Copy link
Author

bump

@stale stale bot removed the lifecycle/stale label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant