Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterViz: Allow user to specify space figure output format in svg/png & savefig kwargs #1823

Open
rht opened this issue Sep 26, 2023 · 0 comments

Comments

@rht
Copy link
Contributor

rht commented Sep 26, 2023

Currently, it is hardcoded to be png, because png is much faster. According to #1819 (comment), we should allow user to pass in extra arguments to solara.FigureMatplotlib. According to https://solara.dev/api/matplotlib, the kwargs is for extra arguments to Matplotlib's savefig, i.e. Solara renders a figure by doing a savefig operation.

cc: @ankitk50. This doesn't require agreement/consensus on the design of how this is going to implemented, and so there shouldn't be any blocker.

@rht rht changed the title JupyterViz: Allow user to specify space figure output format in svg/png JupyterViz: Allow user to specify space figure output format in svg/png & savefig kwargs Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant