Export doesn't work (clicking "Save backup" does nothing)

[mgol]

Opening the extension's preferences and clicking "Save backup" does nothing. Therefore, performing a backup is impossible.

The same button in the original Panorama View extension opens a file save system dialog.

Extension 0.8.7
Firefox 65.0
macOS 10.14.3 (18D42)

[projectdelphai]

I'll check on this, I don't really use the backup feature myself (and someone else has worked on this in the past), I'm sorry I didn't miss this feature breaking. I'll go check on it when I can and see why it doesn't work.

[vaxul]

The code stops at this line:
https://github.com/projectdelphai/panorama-tab-groups/blob/master/src/js/backup.js#L106
The console says TypeError: Argument 1 of StructuredCloneHolder.deserialize is not an object.

🤔

Sadly, it seems the debugger doesn't work properly, I can't even step into the code and look for the part which stops.

This states that it's coming from here:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionChild.jsm#1016

The odd thing is, this logs correct:

browser.sessions.getWindowValue(windows[wi].id, 'groups').then((data) => {
	console.log('groups', data);
});
browser.sessions.getWindowValue(windows[wi].id, 'groupIndex').then((data) => {
	console.log('groupIndex', data);
});
browser.sessions.getWindowValue(windows[wi].id, 'activeGroup').then((data) => {
	console.log('activeGroup', data);
});

and this not:

const groups = await browser.sessions.getWindowValue(windows[wi].id, 'groups');
const groupIndex = await browser.sessions.getWindowValue(windows[wi].id, 'groupIndex');
const activeGroup = await browser.sessions.getWindowValue(windows[wi].id, 'activeGroup');
console.log('groups', groups);
console.log('groupIndex', groupIndex);
console.log('activeGroup', activeGroup);

[HGondorff]

Just wanted to say that this feature is also extremely important to me as well. If Firefox's "Restore previous session" gets unchecked, as happened to me with the v.65 update, you get the "Do you want to close all tabs" when you exit and can't exit without doing it. This causes all tab groups to be lost. Keeping a backup lets you import those tab groups back in. It's a lifesaver.

[vaxul]

In case of @HGondorff an automatic backup would be nice. But this would be a different feature.

[HGondorff]

Just want the Save Backup button to work again, please. Hope someone figures it out.

[ameerdevs]

I've lost all my tab groups multiple times with various Tab Groups extensions over the years (including this one). I don't have the logs/details to reproduce it, but I'd simply open up Firefox one day and find all tab groups as one huge group.

Posting this to +1 a backup/save feature fix

[projectdelphai]

Figured it out, it was extremely stupid. update incoming

[projectdelphai]

It's fixed, basically when some options were added to the options page in the shape of a <form>, there wasn't a corresponding </form> which meant that the save backup button was counted as the button for the form. And because it's not a proper form, the button didn't do anything. Closed the form properly and the button works now. Easy mistake to make and easy to fix, just hard to find :)

git bisect was particularly helpful

[mgol]

@projectdelphai Something got eaten in your comment. ;) Did you use an HTML tag? Markdown understands HTML so if you post code you need to wrap it in backticks or we won't see it.

[HGondorff]

The update is not coming through. I'm still stuck with 0.8.7. I am tempted to delete and download the new version but am afraid of losing my tabs in the process. I have tried setting the updates to default and automatic to no avail.

[projectdelphai]

@HGondorff this link should help you out if you really can't update. That being said, have you tried clicking the little gear on the right hand side of the PTG options page? It'll allow you to automatically download the new update. Firefox only checks once a day, so that might be why your update hasn't come in yet.

If you have tried to manually update, then there might be something else wrong.

[projectdelphai]

@mgol lol yeah i escaped the html tags so it should be good now, thanks for letting me know. Didn't realize backticks helped escape too, I just used back slashes by default and that worked too.

[HGondorff]

Ah yes, the little gear I didn't know was there :) All is well and my anxiety level has declined. My sincere gratitude for the fix!

[projectdelphai]

anytime :)

[ricardoroehe]

Opening the extension's preferences and clicking "Save backup" does nothing. Therefore, performing a backup is impossible.

Same issue here. Noticed it only after restarting Firefox.
Also, I noted the "keyboard shortcuts" fields are empty (like the shortcuts for PTB have been removed). Maybe they could not be read from somewhere (the place where this info was stored)?
I'm not an expert, but it seems incompatibility with some other add-on. PTG was working flawlessly before the restart.

My system:
Firefox 88.0.1 (64-bit) on Linux Mint 19.2 Cinnamon
PTG v. 0.8.12

All add-ons / addons / extensions I have here:

• Adblock Plus - free ad blocker
• All Downloader Professional
• Autofill
• Awesome Emoji Picker
• Best Proxy Switcher
• Change Case
• Chrome Remote Desktop
• Conex
• Copy Link Text
• Download Star
• DownThemAll!
• DuckDuckGo
• Emoji Cheatsheet for GitHub, Basecamp etc.
• Fess Google Bookmark Extension
• Firefox Multi-Account Containers
• Greasemonkey
• Image Search Options
• Panorama Tab Groups
• Rotate and Zoom Image
• Saka Key
• Search by Image
• Startpage
• Stylish - Custom themes for any website
• Video Downloader professional
• Video DownloadHelper
• View Image
• Wikipedia (en)
• Yahoo!
• YouTube Tooltip & Notification
• English (CA) Language Pack
• English (GB) Language Pack