Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyChrono ChFunction example is out of date #479

Open
T-Lind opened this issue Feb 24, 2024 · 1 comment
Open

PyChrono ChFunction example is out of date #479

T-Lind opened this issue Feb 24, 2024 · 1 comment
Assignees

Comments

@T-Lind
Copy link

T-Lind commented Feb 24, 2024

Hi all,

I noticed that the following example:
https://github.com/projectchrono/chrono/blob/main/src/demos/python/core/demo_CH_functions.py
is outdated and runs with an error in its current state (the error stating that ChFunction_Repeat doesn't take any arguments.

Instead of passing f_seq into the constructor, it should be set as the following:

f_rep_seq = chrono.ChFunction_Repeat()
f_rep_seq.Set_fa(f_seq)
@dariomangoni dariomangoni self-assigned this Feb 25, 2024
@dariomangoni
Copy link
Member

Hi T-Lind,
thanks for pointing it out: ChFunctions are indeed one of the oldest part of the code and they have been one of the first to have been reviewed in our current (ongoing) refactoring of the code (see branch overhaul).
We will take care of review the entire ChFunction page quite soon!

Dario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants