Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping exact and regex match for class resources #738

Open
prometherion opened this issue Mar 24, 2023 · 3 comments
Open

Dropping exact and regex match for class resources #738

prometherion opened this issue Mar 24, 2023 · 3 comments
Assignees
Labels
breaking-change needs-discussion No outline on the feature, discussion is welcome
Milestone

Comments

@prometherion
Copy link
Member

Starting from #436, we introduce the support for label selectors of cluster-scoped resources, such as IngressClass, StorageClass, RuntimeClass, and PriorityClass.

At the current state (v0.3.0), we're giving precedence to selectors over exact and regex matches, since Kubernetes is strongly opinionated on the concept of labels and selections.

With that said, for the next Tenant API release, I propose to drop the support of exact and regex matches: this change will put Capsule in a more Kubernetes-native standpoint, and simplify the filtering of resources from the proxy perspective.

@oliverbaehler @MaxFedotov @bsctl please, let's start the discussion.

@prometherion prometherion added the needs-discussion No outline on the feature, discussion is welcome label Mar 24, 2023
@prometherion prometherion added this to the v0.4.0 milestone Mar 24, 2023
@MaxFedotov
Copy link
Collaborator

Although it will be a completely backward-incompatible change, I really love this idea. It will make code faster (get rid of regex, yeeeah!) and simpler. The downside is that users had to update their tenant spec and correctly label their resources, but if it will be a next big major version i think it is ok

@oliverbaehler
Copy link
Collaborator

Agree with @MaxFedotov. We'll just have to create good documentation regarding "how to migrate from regex/exact matches". Just so endusers have an easy path for migration. Also part of my comment here: #737 (comment). Which would required a complete migration anyway. Or mabye we could even do some converions?

@prometherion
Copy link
Member Author

I would postpone this change for v0.6.0 since the upcoming one (v0.5.0) is already adding some fields.

We could take advantage of the new API version that will provide podOptions to remove these fields too.

Let's make this transition as smooth as possible.

@oliverbaehler oliverbaehler modified the milestones: v0.5.0, v0.6.0 Nov 29, 2023
@oliverbaehler oliverbaehler self-assigned this Feb 15, 2024
@oliverbaehler oliverbaehler modified the milestones: v0.6.0, v1.0.0 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change needs-discussion No outline on the feature, discussion is welcome
Projects
None yet
Development

No branches or pull requests

3 participants