Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either flatten crypto_wrappers or add BoringSSL bindings #4917

Open
waywardgeek opened this issue Mar 19, 2024 · 0 comments
Open

Either flatten crypto_wrappers or add BoringSSL bindings #4917

waywardgeek opened this issue Mar 19, 2024 · 0 comments

Comments

@waywardgeek
Copy link
Contributor

The noise_handshake code from the Chromium folks used an abstraction layer around the crypto operations to allow use of Ring crypto, BoringSSL Rust bindings, or Rust crypto. For the initial PR, all but the Rust crypto were deleted, but they were not inlined into the files calling these APIs.

These APIs are Ring-centric and should be cleaned up to be more generic and simpler to use, if we want to support bindings besides Rust crypto. If we do want to support other bindings, we may want to widen this layer so it can be used elsewhere, such as the Oak Restricted Kernel, etc. If not, these APIs should be inlined into the two files that use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant