Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors about missing BUILD deps only come up when importing code into google3 #4633

Open
tiziano88 opened this issue Jan 9, 2024 · 2 comments
Open

Errors about missing BUILD deps only come up when importing code into google3 #4633

tiziano88 opened this issue Jan 9, 2024 · 2 comments

Comments

@tiziano88
Copy link
Collaborator

See #4631 for context

Is there a way of ensuring that we catch this in our CI?
@ernoc
Copy link
Contributor

ernoc commented Mar 12, 2024

Is this still active? Could it be just a matter of adding build_test rules?

@tiziano88
Copy link
Collaborator Author

I think they do build correctly already, but AFAICT blaze has stricter rules for imports from transitive deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiziano88 @ernoc