New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InstaScale controller permissions #56

Closed

anishasthana opened this issue Mar 7, 2023 · 1 comment

Member

anishasthana commented Mar 7, 2023

Basically a dupe of #55, but for InstaScale.
We have a large number of permissions directly defined in the InstaScale controller file: https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/instascale_controller.go#L77-L87

Instead of doing things this way, we should be restricting this set of permissions to those required specifically by the operator (namely https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/instascale_controller.go#L164-L170)
The rest of the permissions should be moved into a (cluster)role and corresponding (cluster)rolebinding in the rbac directory, here: https://github.com/project-codeflare/codeflare-operator/tree/main/config/rbac

anishasthana mentioned this issue

Investigate incorporation of InstaScale into CodeFlare Operator #66

Closed

Contributor

astefanutti commented Sep 25, 2023

This has become obsolete with #279.

astefanutti closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment