Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MWOCTRL cluster returns wrong status and improperly checks power level when not a valid power step increment #33346

Open
rbultman opened this issue May 7, 2024 · 0 comments · May be fixed by #33198
Assignees
Labels
app-clusters Application cluster work appliances Stuff related to appliance types and clusters bug Something isn't working microwaves needs triage

Comments

@rbultman
Copy link
Contributor

rbultman commented May 7, 2024

Reproduction steps

  1. Build and run the microwave oven example app.
  2. Commission the app using chip tool.
  3. Attempt to set the power level to 25.
    Result: The response from the app is INVALID_COMMAND instead of CONSTRAINT_ERROR.

Additionally, the check for a valid power step increment is incorrect. The existing check is:

newPowerLevel % PowerStep == 0

But it should be:

(newPowerLevel - MinPowerLevel) % PowerStep == 0

Bug prevalence

It fails the in-flight test case because it doesn't return the proper response.

GitHub hash of the SDK that was being used

d8e9ef4

Platform

other

Platform Version(s)

No response

Anything else?

No response

@rbultman rbultman added bug Something isn't working needs triage labels May 7, 2024
@rbultman rbultman self-assigned this May 7, 2024
@rbultman rbultman added app-clusters Application cluster work appliances Stuff related to appliance types and clusters microwaves labels May 7, 2024
@rbultman rbultman linked a pull request May 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work appliances Stuff related to appliance types and clusters bug Something isn't working microwaves needs triage
Projects
Status: Todo
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant